Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99337: Fix compile errors with gcc 12 on macOS#99470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ronaldoussoren merged 6 commits intopython:mainfromronaldoussoren:gh-99337
Nov 21, 2022

Conversation

@ronaldoussoren
Copy link
Contributor

@ronaldoussorenronaldoussoren commentedNov 14, 2022•
edited by bedevere-bot
Loading

When compiling with GCC 12 on a macOS 12 system I get three groups of errors:

  1. In pylifecycle.c the compile rejects _Pragma within a declaration
  2. posixmodule.c was missing a number of ..._RUNTIME macros for non-clang on macOS
  3. _ctypes assumed that __builtin_available is always present on macOS

@ronaldoussorenronaldoussoren self-assigned thisNov 15, 2022
@ronaldoussorenronaldoussoren marked this pull request as ready for reviewNovember 15, 2022 08:41
The new form matches the way we test for other weaksymbols (for example in posixmodule.c)
I earlier moved the pragma, but not the comment that explainswhy it is necessary.
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Oh ok, now with the fixed testif (ffi_closure_free != NULL) {, I get it :-)

@miss-islington
Copy link
Contributor

Thanks@ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@ronaldoussoren, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker cdde29dde90947df9bac39c1d19479914fb3db09 3.10

@bedevere-bot
Copy link

GH-99638 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelNov 21, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 21, 2022
Fix a number of compile errors with GCC-12 on macOS:1. In pylifecycle.c the compile rejects _Pragma within a declaration2. posixmodule.c was missing a number of ..._RUNTIME macros for non-clang on macOS3. _ctypes assumed that __builtin_available is always present on macOS(cherry picked from commitcdde29d)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren added a commit that referenced this pull requestNov 21, 2022
…99638)gh-99337: Fix compile errors with gcc 12 on macOS (GH-99470)Fix a number of compile errors with GCC-12 on macOS:1. In pylifecycle.c the compile rejects _Pragma within a declaration2. posixmodule.c was missing a number of ..._RUNTIME macros for non-clang on macOS3. _ctypes assumed that __builtin_available is always present on macOS(cherry picked from commitcdde29d)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@ZeroIntensityZeroIntensity removed the needs backport to 3.10only security fixes labelFeb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@tirantiranAwaiting requested review from tiran

Assignees

@ronaldoussorenronaldoussoren

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronaldoussoren@miss-islington@bedevere-bot@vstinner@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp