python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork34.1k
Star71.6k

Comments

GH-98219: reduce sleep time in`asyncio` subprocess test#99464

Merged

gvanrossum merged 2 commits intopython:mainfrom

kumaraditya303:reduce-sleep

Nov 14, 2022

Merged

GH-98219: reduce sleep time in`asyncio` subprocess test#99464
gvanrossum merged 2 commits intopython:mainfrom
kumaraditya303:reduce-sleep

Conversation

Copy link

Contributor

kumaraditya303 commentedNov 14, 2022•
edited
Loading

Instead of100000000,2 is used so that the test still works but the process completes after 2 sec and hopefully avoid permission errors.

Issue:test.support.os_helper.rmdir(): PermissionError: [WinError 32] The process cannot access the file because it is being used by another process #98219

fix test

c966e5f

kumaraditya303 requested review from1st1,asvetlov andgvanrossum ascode owners

November 14, 2022 09:29

bedevere-bot added awaiting review testsTests in the Lib/test dir labels

Nov 14, 2022

bedevere-bot mentioned this pull request

Nov 14, 2022

test.support.os_helper.rmdir(): PermissionError: [WinError 32] The process cannot access the file because it is being used by another process#98219

Closed

kumaraditya303 added the skip news label

Nov 14, 2022

Copy link

ContributorAuthor

kumaraditya303 commentedNov 14, 2022•
edited
Loading

FWIW this seems to only happen on very slow machines like Github Actions with Windows 10. I have tried to reproduce this on Windows 11 but no luck.

Copy link

ContributorAuthor

kumaraditya303 commentedNov 14, 2022

Windows tests passed, triggering bots again to check again that it works. For reference previous runhttps://github.com/python/cpython/actions/runs/3460146711/jobs/5776365470

Merge branch 'main' into reduce-sleep

b5310db

gvanrossum approved these changes

Nov 14, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Nov 14, 2022

gvanrossum merged commit619cadc intopython:main

Nov 14, 2022

bedevere-bot removed the awaiting merge label

Nov 14, 2022

Copy link

Member

gvanrossum commentedNov 14, 2022

Should this be backported to 3.11?

kumaraditya303 deleted the reduce-sleep branch

November 15, 2022 11:00

kumaraditya303 added the needs backport to 3.11only security fixes label

Nov 15, 2022

Copy link

Contributor

miss-islington commentedNov 15, 2022

Thanks@kumaraditya303 for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

Copy link

bedevere-bot commentedNov 15, 2022

GH-99504 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 15, 2022

pythonGH-98219: reduce sleep time inasynciosubprocess test (pytho…

a673707

…nGH-99464)(cherry picked from commit619cadc)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

bedevere-bot removed the needs backport to 3.11only security fixes label

Nov 15, 2022

Copy link

ContributorAuthor

kumaraditya303 commentedNov 15, 2022

Should this be backported to 3.11?

Yes!

miss-islington added a commit that referenced this pull request

Nov 15, 2022

GH-98219: reduce sleep time inasynciosubprocess test (GH-99464)

e1e8a15

(cherry picked from commit619cadc)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

Copy link

bedevere-bot commentedNov 15, 2022

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotPPC64LE Fedora Stable Clang Installed 3.11 has failed when building commite1e8a15.

What do you need to do:

Don't panic.
Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1003/builds/439) and take a look at the build logs.
Check if the failure is related to this commit (e1e8a15) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1003/builds/439

Summary of the results of the build (if available):

Click to see traceback logs

fatal:unable to access 'https://github.com/python/cpython.git/': Could not resolve host: github.comchmod:cannot access 'target/': No such file or directorymake:*** No rule to make target 'distclean'.  Stop.

Copy link

bedevere-bot commentedNov 15, 2022

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotPPC64LE Fedora Stable Clang Installed 3.11 has failed when building commite1e8a15.

What do you need to do:

Don't panic.
Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1003/builds/440) and take a look at the build logs.
Check if the failure is related to this commit (e1e8a15) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1003/builds/440

Summary of the results of the build (if available):

Click to see traceback logs

fatal:unable to access 'https://github.com/python/cpython.git/': Could not resolve host: github.comchmod:cannot access 'target/': No such file or directorymake:*** No rule to make target 'distclean'.  Stop.

Copy link

Member

gvanrossum commentedNov 15, 2022

Do the buildbot failures look like our fault?

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Nov 16, 2022

Merge branch 'main' into fix-issue21914

abd206e

* main: (8272 commits)  Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496)  Post 3.12.0a2pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)pythongh-99300: Use Py_NewRef() in Doc/ directory  (python#99480)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371)  ...