Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99433: Fixdoctest failure onMethodWrapperType#99434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 1 commit intopython:mainfromsobolevn:issue-99433
Dec 30, 2022

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedNov 13, 2022•
edited
Loading

Looks like it was failing becauseisroutine now hasismethodwrapper check. While_from_module was not having one. Refshttps://github.com/python/cpython/blame/57be5459593bbd09583317ebdafc4d58ae51dbf4/Lib/inspect.py#L509

New test failure without the code change:

======================================================================FAIL: basics (test.test_doctest.test_DocTestFinder)Doctest: test.test_doctest.test_DocTestFinder.basics----------------------------------------------------------------------Traceback (most recent call last):  File "/Users/sobolev/Desktop/cpython/Lib/doctest.py", line 2221, in runTest    raise self.failureException(self.format_failure(new.getvalue()))AssertionError: Failed doctest test for test.test_doctest.test_DocTestFinder.basics  File "/Users/sobolev/Desktop/cpython/Lib/test/test_doctest.py", line 437, in basics----------------------------------------------------------------------File "/Users/sobolev/Desktop/cpython/Lib/test/test_doctest.py", line 649, in test.test_doctest.test_DocTestFinder.basicsFailed example:    tests = doctest.DocTestFinder(exclude_empty=False).find(doctest_lineno)Exception raised:    Traceback (most recent call last):      ...    ValueError: object must be a class or function----------------------------------------------------------------------

This would need a backport to3.11

@sobolevn
Copy link
MemberAuthor

@larryhastings@isidentical you work oninspect quite a lot, maybe you would have time to take a look? :)

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100620 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelDec 30, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 30, 2022
…ythonGH-99434)(cherry picked from commit79c10b7)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull requestDec 30, 2022
(cherry picked from commit79c10b7)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@sobolevn@miss-islington@bedevere-bot@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp