Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac#99406

Merged
kumaraditya303 merged 1 commit intopython:mainfrom
thesamesam:more-clang16
Nov 26, 2022
Merged

gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac#99406
kumaraditya303 merged 1 commit intopython:mainfrom
thesamesam:more-clang16

Conversation

@thesamesam
Copy link
Contributor

@thesamesamthesamesam commentedNov 12, 2022•
edited by bedevere-bot
Loading

…n fixes

Followup to12078e7. I ended up missing a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is <stddef.h> for size_t.

See:12078e7
Signed-off-by: Sam Jamessam@gentoo.org

@thesamesam
Copy link
ContributorAuthor

cc@erlend-aasland@kumaraditya303, followup from#99085.

Apologies for missing a few!

As penance, I'm going to do a followup now (but not generate configure yet as it won't be suitable to merge unless/until this is) in another PR for someAC_LANG_SOURCE porting (not doing it here to ease backporting).

erlend-aasland reacted with thumbs up emoji

@thesamesam
Copy link
ContributorAuthor

ping

…aration fixesFollowup to12078e7. I ended up missinga few, apparently.Clang 16 makes -Wimplicit-function-declaration an error by defaultand warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypeswhile we're here and it futureproofs us, so throw that in.The only notable part of this which might not be super obvious is<stddef.h> for size_t.See:12078e7
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine but I would like a review from@erlend-aasland

erlend-aasland and thesamesam reacted with thumbs up emoji
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, looks good to me! Sorry for the delay.

kumaraditya303 and thesamesam reacted with heart emoji
@kumaraditya303kumaraditya303 changed the titlegh-99086: Further -Wstrict-prototypes, -Wimplicit-function-declaratio…gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.acNov 26, 2022
@miss-islington
Copy link
Contributor

Thanks@thesamesam for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry,@thesamesam and@kumaraditya303, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker e35ca417fe81a64985c2b29e863ce418ae75b96e 3.11

@miss-islington
Copy link
Contributor

Sorry@thesamesam and@kumaraditya303, I had trouble checking out the3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker e35ca417fe81a64985c2b29e863ce418ae75b96e 3.10

@kumaraditya303
Copy link
Contributor

@thesamesam Can you create the backports? thanks

@thesamesam
Copy link
ContributorAuthor

@kumaraditya303 Happy to, thanks folks!

@thesamesamthesamesam deleted the more-clang16 branchNovember 30, 2022 06:39
thesamesam added a commit to thesamesam/cpython that referenced this pull requestDec 1, 2022
…eclaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7.(cherry picked from commite35ca41)
thesamesam added a commit to thesamesam/cpython that referenced this pull requestDec 1, 2022
…eclaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7.(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this pull requestDec 1, 2022
…eclaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7..(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
@bedevere-bot
Copy link

GH-99919 is a backport of this pull request to the3.11 branch.

@bedevere-bot
Copy link

GH-99920 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelDec 1, 2022
@bedevere-bot
Copy link

GH-99920 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit that referenced this pull requestDec 1, 2022
GH-99919)…tion warnings in configure.ac (GH-99406)Follow up to12078e7. (cherry picked from commite35ca41)
kumaraditya303 pushed a commit that referenced this pull requestDec 1, 2022
#99920)[3.10]gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (GH-99406)Follow up to12078e7.(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestMay 21, 2024
…eclara… (python#99920)[3.10]pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7.(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestMay 21, 2024
…eclara… (python#99920)[3.10]pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7.(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…eclara… (python#99920)[3.10]pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7.(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…eclara… (python#99920)[3.10]pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7.(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestJul 30, 2025
…eclara… (python#99920)[3.10]pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)Follow up to12078e7.(cherry picked from commite35ca41)Co-authored-by: Sam James <sam@gentoo.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

@kumaraditya303kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thesamesam@miss-islington@kumaraditya303@bedevere-bot@erlend-aasland
[8]ページ先頭
©2009-2026 Movatter.jp