Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
GH-99205: remove_static field fromPyThreadState andPyInterpreterState#99385
GH-99205: remove_static field fromPyThreadState andPyInterpreterState#99385miss-islington merged 3 commits intopython:mainfrom
_static field fromPyThreadState andPyInterpreterState#99385Conversation
83e3c4b to73d60caCompare
ericsnowcurrently left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for working this. I recommend a slight tweak the comments and then this is ready go.
Uh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedNov 14, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
* main: (8272 commits) Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496) Post 3.12.0a2pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)pythongh-99300: Use Py_NewRef() in Doc/ directory (python#99480)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371) ...
Uh oh!
There was an error while loading.Please reload this page.
PyThreadStateandPyInterpreterStateare not freed #99205Automerge-Triggered-By: GH:ericsnowcurrently