Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-93649: Split getargs testing from _testcapimodule.c#99346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-93649: Split getargs testing from _testcapimodule.c#99346
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- a couple of PEP 7 nits- use intermingled decls a few places- Use Py_NewRef() API to save a few lines
erlend-aasland commentedNov 11, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There is some fishy error handling in some of the test methods. Let's handle those in a separate issue/PR. An example is |
Leaks in failing tests? The only situation I see where that's is a problem is when tests are used as API usage examples. So, it's good to fix those, but not too important for older tests. Undefining |
Yes, only in error handling paths, and it's not a problem in practice.
+1 |
* main: (8272 commits) Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496) Post 3.12.0a2pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)pythongh-99300: Use Py_NewRef() in Doc/ directory (python#99480)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371) ...
Uh oh!
There was an error while loading.Please reload this page.