Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99201: fix IndexError when initializing sysconfig config variables#99274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FFY00 merged 1 commit intopython:mainfromFFY00:gh-99201
Nov 19, 2022

Conversation

@FFY00
Copy link
Member

@FFY00FFY00 commentedNov 9, 2022•
edited by bedevere-bot
Loading

…iablesSigned-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
MemberAuthor

@philthompson10, can you confirm this fixes your issue?

@philthompson10
Copy link

philthompson10 commentedNov 9, 2022 via email

On 09/11/2022 03:36, Filipe Laíns wrote:@philthompson10, can you confirm this fixes your issue?
Yes but I think a safer fix would be to set vars['EXT_SUFFIX'] to Noneor ''. There might be code that is expecting the dict to have a valuewith that key (as it currently does in all circumstances) and also thatthat value is a string.Phil

@FFY00
Copy link
MemberAuthor

The existence ofEXT_SUFFIX is not guaranteed, as it is not documented anywhere. People expecting it to be there is the reason why I think we shouldn't set it at all. ReturningNone will make code that uses the string value of the returned object misbehave (eg.f'my_extension{sysconfig.get_config_var("EXT_SUFFIX")}' will bemy_extensionNone), so raising aKeyError in these situations is more desirable.

@FFY00FFY00 merged commitb0e1f9c intopython:mainNov 19, 2022
@FFY00FFY00 deleted the gh-99201 branchNovember 19, 2022 20:47
@FFY00FFY00 restored the gh-99201 branchAugust 8, 2023 01:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FFY00@philthompson10@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp