Dec 18, 2022 · Nov 8, 2022 · Nov 15, 2022 · Nov 15, 2022 · Nov 17, 2022 · Nov 17, 2022
diff --git a/Doc/library/inspect.rst b/Doc/library/inspect.rst
      wrapped function is a :term:`coroutine function`.


 .. function:: markcoroutinefunction(object)

   Decorator to mark a callable as a :term:`coroutine function` if it would not
   otherwise be detected by :func:`iscoroutinefunction`.

   This may be of use for sync functions that return an awaitable or objects
   implementing an :keyword:`async def` ``__call__``.

   Prefer :keyword:`async def` functions or calling the function and testing
   the return with :func:`isawaitable` where feasible.

   .. versionadded:: 3.12


 .. function:: iscoroutine(object)

   Return ``True`` if the object is a :term:`coroutine` created by an
diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py
                    gen_coroutine_function_example))))
        self.assertTrue(inspect.isgenerator(gen_coro))

        # Use subtest initially to see both failures.
        with self.subTest("Wrapper not recognised."):
            # First case: sync function returning an awaitable.
            async def _fn3():
                pass

            def fn3():
                return _fn3()
            self.assertTrue(inspect.iscoroutinefunction(fn3))

        with self.subTest("Awaitable instance not recongnised."):
            # Second case: a class with an async def __call__.
            # - instance is awaitable.
            class Cl:
                async def __call__(self):
                    pass
            cl = Cl()
            self.assertTrue(inspect.iscoroutinefunction(cl))

        self.assertFalse(
            inspect.iscoroutinefunction(unittest.mock.Mock()))
        self.assertTrue(
Original file line number	Diff line number	Diff line change
Expand Up		@@ -358,6 +358,20 @@ attributes:
		wrapped function is a :term:`coroutine function`.


		.. function:: markcoroutinefunction(object)
carltongibson marked this conversation as resolved. OutdatedShow resolvedHide resolved

		Decorator to mark a callable as a :term:`coroutine function` if it would not
		otherwise be detected by :func:`iscoroutinefunction`.

		This may be of use for sync functions that return an awaitable or objects
		implementing an :keyword:`async def` ``__call__``.

		Prefer :keyword:`async def` functions or calling the function and testing
		the return with :func:`isawaitable` where feasible.

		.. versionadded:: 3.12


		.. function:: iscoroutine(object)

		Return ``True`` if the object is a :term:`coroutine` created by an
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -202,6 +202,25 @@ def test_iscoroutine(self):
		gen_coroutine_function_example))))
		self.assertTrue(inspect.isgenerator(gen_coro))

		# Use subtest initially to see both failures.
		with self.subTest("Wrapper not recognised."):
		# First case: sync function returning an awaitable.
		async def _fn3():
		pass

		def fn3():
		return _fn3()
		self.assertTrue(inspect.iscoroutinefunction(fn3))

		with self.subTest("Awaitable instance not recongnised."):
		# Second case: a class with an async def __call__.
		# - instance is awaitable.
		class Cl:
		async def __call__(self):
Copy link Member sobolevnNov 15, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. In the future don't forget to test objects with`.__func__` set, because of how`_has_code_flag` works :) Copy link ContributorAuthor carltongibsonNov 15, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I haven't followed exactly what you mean here. Sorry. 🤔 Copy link Member sobolevnNov 17, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Oh, sorry. I've meant that objects like`staticmethod` and`classmethod` have`__func__` property set, where the original function is stored.`inspect` generally supports this pattern and it should be tested in this case as well :) Copy link ContributorAuthor carltongibsonNov 17, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. @sobolevn — OK, let me have a play and see. Thanks!
		pass
		cl = Cl()
		self.assertTrue(inspect.iscoroutinefunction(cl))

		self.assertFalse(
		inspect.iscoroutinefunction(unittest.mock.Mock()))
		self.assertTrue(
Expand Down