Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99211: Point to except/except* on syntax errors when mixing them#99215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

lysnikolaou
Copy link
Member

@lysnikolaoulysnikolaou commentedNov 7, 2022•
edited by miss-islington
Loading

Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@iritkatrieliritkatriel added skip news 3.11only security fixes 3.12only security fixes labelsNov 20, 2022
@iritkatriel
Copy link
Member

Added skip news because my PR had a news item that covers this (and is not too specific).

I think we should backport this to 3.11. Would you agree?

@lysnikolaou
Copy link
MemberAuthor

lysnikolaou commentedNov 20, 2022•
edited
Loading

I think we should backport this to 3.11. Would you agree?

Yup, I think it makes sense since#99160 was also backported.

@lysnikolaou
Copy link
MemberAuthor

Also, I've pushed another change, so another quick review would be nice.

@iritkatrieliritkatriel added the needs backport to 3.11only security fixes labelNov 20, 2022
@iritkatriel
Copy link
Member

LGTM, but I'm not a parser expert.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islingtonmiss-islington merged commit9c4232a intopython:mainNov 20, 2022
@miss-islington
Copy link
Contributor

Thanks@lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@lysnikolaou, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 9c4232ae8972a33f84e875cfdd866318a1233e47 3.11

@miss-islingtonmiss-islington self-assigned thisNov 20, 2022
@bedevere-bot
Copy link

GH-99622 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelNov 20, 2022
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull requestNov 20, 2022
…them (pythonGH-99215)Automerge-Triggered-By: GH:lysnikolaou(cherry picked from commit9c4232a)
lysnikolaou added a commit that referenced this pull requestNov 20, 2022
… them (GH-99215) (GH-99622)gh-99211: Point to except/except* on syntax errors when mixing them (GH-99215)(cherry picked from commit9c4232a)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

Assignees

@miss-islingtonmiss-islington

Labels
3.11only security fixes3.12only security fixesskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@lysnikolaou@iritkatriel@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp