Movatterモバイル変換

TypeError whenexcept* catches an unhashable exception#99181

Closed

bedevere-bot added the awaiting core review label

iritkatriel added type-bug

An unexpected behavior, bug, or error

needs backport to 3.11only security fixes labels

iritkatriel requested a review fromgvanrossum

November 7, 2022 10:04

iritkatriel added2 commits

November 7, 2022 10:06

fix typo in comment

64406d6

rename exc_key --> exc_id

e725f63

iritkatriel added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Copy link

bedevere-bot commentedNov 7, 2022

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit47842ab 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

iritkatriel force-pushed theunhashable branch from47842ab toe725f63Compare

November 7, 2022 10:27

📜🤖 Added by blurb_it.

9f8a78d

iritkatriel added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Copy link

bedevere-bot commentedNov 7, 2022

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit9f8a78d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

kumaraditya303 reviewed

Lib/test/test_except_star.py OutdatedShow resolvedHide resolved

kumaraditya303 reviewed

Lib/test/test_except_star.py OutdatedShow resolvedHide resolved

hash-->__hash__

094bb0c

JelleZijlstra reviewed

Lib/test/test_except_star.pyShow resolvedHide resolved

add test with broken __eq__

9d4bea8

JelleZijlstra self-requested a review

November 7, 2022 18:29

JelleZijlstra approved these changes

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Using the ids here seems safe because they are used only while the code holds a reference to the BaseExceptionGroup object and that object is immutable, so there's no chance that the ids will get reused while the code is running.

bedevere-bot added awaiting merge and removed awaiting core review labels

iritkatriel merged commitc43714f intopython:main

Copy link

Contributor

miss-islington commentedNov 8, 2022

Thanks@iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-99181: fix except* on unhashable exceptions (pythonGH-99192)

66aea6e

(cherry picked from commitc43714f)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

Copy link

bedevere-bot commentedNov 8, 2022

GH-99243 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

miss-islington added a commit that referenced this pull request