Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99086: Fix implicit int warning in configure check for PTHREAD_SCOPE_SYSTEM (#99085)#99085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 3 commits intopython:mainfromthesamesam:clang-16
Nov 5, 2022

Conversation

@thesamesam
Copy link
Contributor

@thesamesamthesamesam commentedNov 4, 2022•
edited by bedevere-bot
Loading

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:

conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]

Signed-off-by: Sam Jamessam@gentoo.org

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@ghost
Copy link

ghost commentedNov 4, 2022•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

thesamesam added a commit to thesamesam/cpython that referenced this pull requestNov 4, 2022
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
@thesamesamthesamesam changed the titleconfigure.ac: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM checkh-99086: Build: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM check (#99085)Nov 4, 2022
@thesamesamthesamesam changed the titleh-99086: Build: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM check (#99085)gh-99086: Build: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM check (#99085)Nov 4, 2022
thesamesam added a commit to thesamesam/cpython that referenced this pull requestNov 4, 2022
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@kumaraditya303kumaraditya303 added type-bugAn unexpected behavior, bug, or error needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsNov 4, 2022
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One small nit regarding the NEWS entry. The AC fix is fine with me, but IMO usingAC_LANG_PROGRAM iso.AC_LANG_SOURCE would have been better.

@erlend-aaslanderlend-aasland self-assigned thisNov 4, 2022
@erlend-aaslanderlend-aasland changed the titlegh-99086: Build: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM check (#99085)gh-99086: Fix implicit int warning in configure check for PTHREAD_SCOPE_SYSTEM (#99085)Nov 4, 2022
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestNov 4, 2022
These warnings became fatal by default in Clang 16.Most of this has since been fixed upstream butpython#99085 is pending.Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam
Copy link
ContributorAuthor

One small nit regarding the NEWS entry. The AC fix is fine with me, but IMO usingAC_LANG_PROGRAM iso.AC_LANG_SOURCE would have been better.

Ah, that's a fair point. I've got an absolute tonne of these to fix (https://lwn.net/SubscriberLink/913505/b61bbc0c4296117f/) so I've been trying to make non-invasive changes. Is it alright if I leave this one as-is?

@erlend-aasland
Copy link
Contributor

Ah, that's a fair point. I've got an absolute tonne of these to fix (https://lwn.net/SubscriberLink/913505/b61bbc0c4296117f/) so I've been trying to make non-invasive changes. Is it alright if I leave this one as-is?

Yeah, leave this as it is. We can get rid ofAC_LANG_SOURCE in a separate issue/PR.

@erlend-aaslanderlend-aasland merged commit12078e7 intopython:mainNov 5, 2022
@miss-islington
Copy link
Contributor

Thanks@thesamesam for the PR, and@erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@thesamesam and@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 12078e78f6e4a21f344e4eaff529e1ff3b97734f 3.11

@miss-islington
Copy link
Contributor

Sorry@thesamesam and@erlend-aasland, I had trouble checking out the3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 12078e78f6e4a21f344e4eaff529e1ff3b97734f 3.10

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull requestNov 5, 2022
… check for PTHREAD_SCOPE_SYSTEM (pythonGH-99085)(cherry picked from commit12078e7)Co-authored-by: Sam James <sam@cmpct.info>
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull requestNov 5, 2022
… check for PTHREAD_SCOPE_SYSTEM (pythonGH-99085)(cherry picked from commit12078e7)Co-authored-by: Sam James <sam@cmpct.info>
@bedevere-bot
Copy link

GH-99118 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelNov 5, 2022
@bedevere-bot
Copy link

GH-99119 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelNov 5, 2022
erlend-aasland added a commit that referenced this pull requestNov 5, 2022
… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99118)(cherry picked from commit12078e7)Co-authored-by: Sam James <sam@cmpct.info>
@thesamesam
Copy link
ContributorAuthor

thesamesam commentedNov 5, 2022•
edited
Loading

Thank you!

erlend-aasland reacted with heart emoji

@thesamesamthesamesam deleted the clang-16 branchNovember 5, 2022 18:31
erlend-aasland added a commit that referenced this pull requestNov 6, 2022
… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99119)(cherry picked from commit12078e7)Co-authored-by: Sam James <sam@cmpct.info>Co-authored-by: Sam James <sam@cmpct.info>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestMay 21, 2024
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestMay 21, 2024
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestJul 30, 2025
…ck (python#99085)Clang 16 makes -Wimplicit-int fatal by default.Avoids errors like:```conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]```Signed-off-by: Sam James <sam@gentoo.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thesamesam@bedevere-bot@erlend-aasland@miss-islington@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp