Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-94199: Remove ssl.wrap_socket() documentation#99023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 5 commits intopython:mainfromvstinner:ssl_doc
Nov 3, 2022
Merged

gh-94199: Remove ssl.wrap_socket() documentation#99023

vstinner merged 5 commits intopython:mainfromvstinner:ssl_doc
Nov 3, 2022

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedNov 2, 2022•
edited by bedevere-bot
Loading

The function has been removed. In the ssl documentation, replace references to the ssl.wrap_socket() function with references to the ssl.SSLContext.wrap_socket() method.

The function has been removed. In the ssl documentation, replacereferences to the ssl.wrap_socket() function with references to thessl.SSLContext.wrap_socket() method.
@vstinner
Copy link
MemberAuthor

cc@illia-v

Copy link
Contributor

@illia-villia-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for updating the doc!

Some arguments ofssl.wrap_socket are no longer present inSSLContext.wrap_socket.

@vstinner
Copy link
MemberAuthor

@illia-v: I updated my PR, would you mind to review it? I removed references to non-existing parameters.

I made it clear the wrap_socket() is now the only way to create SSL socket objects, as already stated in the SSLSocket documentation:https://docs.python.org/dev/library/ssl.html#ssl.SSLSocket

Instances of SSLSocket must be created using the SSLContext.wrap_socket() method.

Comment on lines 2053 to 2054
case, only the ``certfile`` parameter to :meth:`SSLContext.load_cert_chain`
and :func:`wrap_socket` needs to be passed. If the private key is stored
and :meth:`SSLContext.wrap_socket` needs to be passed. If the private key is stored
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

SSLContext.wrap_socket has nocertfile parameter

vstinnerand others added2 commitsNovember 3, 2022 12:33
Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
@vstinnervstinner merged commitcff1c20 intopython:mainNov 3, 2022
@vstinnervstinner deleted the ssl_doc branchNovember 3, 2022 12:33
@vstinner
Copy link
MemberAuthor

Thanks@illia-v, it was more complicated than expected. Not just a simple text replace before/after ;-)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@illia-villia-villia-v approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@illia-v@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp