Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-98790: When DLLs directory is missing on Windows, assume executable_dir contains PYD files instead#98936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…cutable_dir contains PYD files instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As I mentioned in#98790 (comment), I think trying to make the behavior closer to what it used to be is the right approach for now, so I am in favor of this fix 👍
We're quite a way away from the old behaviour, which was basically a hard-coded (incorrect) default. What I just pushed is going to handle the missing Also dropped the search on Windows, which we never used to do and is just as unsafe on Windows as it is anywhere else. |
Thanks@zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry,@zooba, I could not cleanly backport this to |
bedevere-bot commentedNov 2, 2022
GH-99019 is a backport of this pull request to the3.11 branch. |
…cutable_dir contains PYD files instead (pythonGH-98936)
…e_dir contains PYD files instead (GH-98936)
This appears to have caused a regression in 3.11.1 forcing some people to stick with 3.11.0:#100171 |
Uh oh!
There was an error while loading.Please reload this page.
<exec_prefix>#98790