Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-98852: Fix subscription of type aliases#98920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:typing-subscribe-non-genericNov 1, 2022
Merged
gh-98852: Fix subscription of type aliases#98920
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:typing-subscribe-non-genericNov 1, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fix subscription of type aliases containing bare generic types or typeslike TypeVar: for example tuple[A, T][int] and tuple[TypeVar, T][int],where A is a generic type, and T is a type variable.
Fidget-Spinner approved these changesNov 1, 2022
Contributor
miss-islington commentedNov 1, 2022
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 1, 2022
Fix subscription of type aliases containing bare generic types or typeslike TypeVar: for example tuple[A, T][int] and tuple[TypeVar, T][int],where A is a generic type, and T is a type variable.(cherry picked from commit0e15c31)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot commentedNov 1, 2022
GH-98952 is a backport of this pull request to the3.11 branch. |
miss-islington added a commit that referenced this pull requestNov 1, 2022
Fix subscription of type aliases containing bare generic types or typeslike TypeVar: for example tuple[A, T][int] and tuple[TypeVar, T][int],where A is a generic type, and T is a type variable.(cherry picked from commit0e15c31)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot commentedNov 1, 2022
GH-98969 is a backport of this pull request to the3.10 branch. |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestNov 1, 2022
…es (pythonGH-98920)Fix subscription of types.GenericAlias instances containing bare generic types:for example tuple[A, T][int], where A is a generic type, and T is a typevariable.
serhiy-storchaka added a commit that referenced this pull requestNov 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix subscription of type aliases containing bare generic types or types like TypeVar: for example tuple[A, T][int] and tuple[TypeVar, T][int], where A is a generic type, and T is a type variable.