Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-98762: Fix locations of match sub-patterns#98775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 7 commits intopython:mainfromiritkatriel:match
Nov 12, 2022

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedOct 27, 2022•
edited by bedevere-bot
Loading

This PR removes the recursive updates which made the locations incorrect.

They are still too broad in some cases, but we should deal with the separately. (One thing we would need to do is to save the locations of identifiers alongside the "stores" list.)

@iritkatrieliritkatriel added type-bugAn unexpected behavior, bug, or error interpreter-core(Objects, Python, Grammar, and Parser dirs) labelsOct 27, 2022
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine to me, but I'll leave it to@brandtbucher to review as he wrote the pattern matching code.

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for tackling this!

@brandtbucherbrandtbucher changed the titlegh-98762: Fix locations of match sub-expressionsgh-98762: Fix locations of match sub-patternsNov 11, 2022
iritkatrieland others added3 commitsNovember 11, 2022 23:17
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@iritkatrieliritkatriel merged commitfb844e1 intopython:mainNov 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon left review comments

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees

@brandtbucherbrandtbucher

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel@markshannon@brandtbucher@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp