Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-98636: Fix detecting gdbm_compat for _dbm module#98643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 1 commit intopython:mainfrommgorny:gdbm_compat-98636
Jan 11, 2023

Conversation

@mgorny
Copy link
Contributor

@mgornymgorny commentedOct 25, 2022•
edited
Loading

Fix the gdbm_compat library detection logic to actually check for
-lgdbm_compat independently of the ndbm detection. This fixes the build
failure with--with-dbmliborder=gdbm, and implicit fallback to ndbm
with the default value.

@mgorny
Copy link
ContributorAuthor

Ping.

@mgorny
Copy link
ContributorAuthor

Another ping. It would be really nice to have this fixed.

Fix the gdbm_compat library detection logic to actually check for-lgdbm_compat independently of the ndbm detection.  This fixes the buildfailure with `--with-dbmliborder=gdbm`, and implicit fallback to ndbmwith the default value.
@mgorny
Copy link
ContributorAuthor

@erlend-aasland, updated as requested.

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
Contributor

Does this need a backport?

@mgorny
Copy link
ContributorAuthor

Does this need a backport?

Unless I'm mistaken, no. The issue was introduced inec5e253, and FWICS this in 3.12 only.

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
Contributor

Thanks, and sorry for the delay!

If you want to pursue the AC refactorings discussed, please open an issue/PR.

thesamesam reacted with heart emoji

@mgorny
Copy link
ContributorAuthor

Thank you! I'm happy enough having the immediate problem fixed.

erlend-aasland reacted with thumbs up emoji

@mgornymgorny deleted the gdbm_compat-98636 branchJanuary 12, 2023 06:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgorny@erlend-aasland@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp