Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.6k
gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew#98583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
974596e to3f17a8eComparepablogsal commentedOct 24, 2022
The docs are failing due to: WARNING: undefined label: deprecated-aliases |
Doc/whatsnew/3.11.rst Outdated
| *:func:`!sqlite3.enable_shared_cache` | ||
| *:func:`!sqlite3.OptimizedUnicode` | ||
| *:mod:`unittest` ``fail*`` and ``assert*``:ref:`deprecated-aliases` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| *:mod:`unittest` ``fail*`` and ``assert*``:ref:`deprecated-aliases` | |
| *:mod:`unittest` ``fail*`` and ``assert*`` deprecated-aliases |
The section was removed inGH-92556.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's unfortunate because the line is hard to understand without links. As I understand it doesn't refer to all assert* method, just old aliases likeassertEquals. Maybe we'll have to list the methods explicitly here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes. IMO the removed table should have been moved here. I'll make a commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pushed directly to CAM's branch, as it would have been awkward as a suggestion or PR-for-a-PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the help and sorry for not being around; I was getting a few hours of sleep after staying at the office way too late past 4 am working on these.
Yeah, the table was removed but in3.12 and still present in 3.11 where it mattered; my plan was to write the What's New against what would work in 3.11, and then go back later and fix the missing stuff for 3.12+, but I mistakenly thought the undefined label warning was due to-n rather than on by default (and an error with-W). In that case, just adding the full table was the best thing to do given the circumstances.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington commentedOct 24, 2022
Thanks@CAM-Gerlach for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…New (pythonGH-98583)* Fix names/references of pending removal APIs* Sort list of APIs pending removal alphabetically* Add missing modules/submodules pending removal in 3.12* Add table of unittest deprecated aliases to 3.11 What's NewCo-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>(cherry picked from commite19c2b9)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
bedevere-bot commentedOct 24, 2022
GH-98600 is a backport of this pull request to the3.11 branch. |
…H-98583)* Fix names/references of pending removal APIs* Sort list of APIs pending removal alphabetically* Add missing modules/submodules pending removal in 3.12* Add table of unittest deprecated aliases to 3.11 What's NewCo-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>(cherry picked from commite19c2b9)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Uh oh!
There was an error while loading.Please reload this page.
Part of#95913
This PR copyedits, sorts and fixes the syntax of the Pending Removal section of the What's New in Python 3.11 document. In particular, it:
It also adds several missing modules pending removal in 3.12 but not previously listed, specifically:
asynchatasyncoreimptyping.ionamespacetyping.renamespaceassert*andfail*) in theunittestmodule that were bumped from 3.11 to 3.12 in beta 1, but not listed anywhere in the document