Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Fix: Mac/Extras.install.py，Can not filter osx .DS_store file#98579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bedevere-bot commentedOct 24, 2022
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
ghost commentedOct 24, 2022
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
| ifname=='CVS':return0 | ||
| ifname=='.cvsignore':return0 | ||
| ifname=='.DS_store':return0 | ||
| ifname=='.DS_Store':return0 | ||
| ifname=='.svn':return0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ifname=='CVS':return0 | |
| ifname=='.cvsignore':return0 | |
| ifname=='.DS_store':return0 | |
| ifname=='.DS_Store':return0 | |
| ifname=='.svn':return0 | |
| ifnamein ('CVS','.cvsignore','.DS_store','.DS_Store','.svn')`: | |
| return0 |
A proof-of-concept:
>>>deftest(name):...returnnamein ('CVS','.cvsignore','.DS_store','.DS_Store','.svn')...>>>test('fooCVS')False>>>test('foo')False>>>test('CVS')True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
simple and better performance
zhangbo2012 commentedOct 24, 2022
Sorry , I use a wrong email, cannot sign Contributor License Agreement@arhadthedev I'll create a new PR |
arhadthedev commentedOct 24, 2022
For history: the new PR isgh-98580. |
Mac/Extras.install.py，Can not filter osx DS_store file
As
But in OSX, Real File Name is
.DS_Store, like this(venv) zhangbo@zhangbodeMacBook-Pro a2 % ll -atotal 16drwxr-xr-x 4 zhangbo staff 128 Oct 22 17:34.drwxr-xr-x 8 zhangbo staff 256 Oct 22 17:18 ..-rw-r--r--@ 1 zhangbo staff 6148 Oct 22 17:17 .DS_Storedrwxr-xr-x 3 zhangbo staff 96 Oct 22 17:23 123So we need update
.DS_storeto.DS_Store