Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.11] gh-98548: Fix-ne
shell operator spelling#98556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bedevere-bot commentedOct 22, 2022
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
hauntsaninja left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for spotting this!
Here is an example workflow run affected:https://github.com/python/cpython/actions/runs/3293756628/jobs/5430563962
That said, I'm not sure this is enough of a fix, because I think Github Actions runs withbash -e
. So I think we'd never get to this anyway? One option would be to use|| (echo ... ; exit 1)
or something
Since the command expected to fail is short enough, maybe just if! make check-abidump;thenecho ...fi is sufficient? The |
hauntsaninja left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, this looks good to me. Want to update the 3.10 backport#98555 as well? :-) cc@JelleZijlstra
Updated#98555 too. |
Backport the workflow change and fix-ups:-pythonGH-92442 (e89c01e)-pythonGH-94129 (0dadb22)-pythonGH-98556 (194588d)Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com>
gh-98548: Workflow not equal operator spelling
This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.
This bug is present on 3.10 and 3.11 branches only.
This follows#98555 for another affected branch.