Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-98539: fix ref cycle in_SSLProtocolTransport after close#98540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 1 commit intopython:mainfromkumaraditya303:ssl-fix
Oct 22, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commentedOct 22, 2022•
edited by bedevere-bot
Loading

@miss-islington
Copy link
Contributor

Thanks@kumaraditya303 for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 22, 2022
…ythonGH-98540)(cherry picked from commit62bf5d8)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98551 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelOct 22, 2022
@kumaraditya303kumaraditya303 deleted the ssl-fix branchOctober 22, 2022 16:13
gvanrossum pushed a commit that referenced this pull requestOct 24, 2022
…GH-98540) (#98551)GH-98539: fix ref cycle in `_SSLProtocolTransport` after close  (GH-98540)(cherry picked from commit62bf5d8)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
pquentin added a commit to pquentin/rally that referenced this pull requestMay 4, 2023
Sincepython/cpython#98540 which was included inPython 3.11.1, aiohttp can fail if two tasks are trying to close theconnection concurrently.
bdraco added a commit to home-assistant/core that referenced this pull requestMay 13, 2023
There is currently a relatively fast memory leak when usingcpython 3.11.2+ and cleanup_closed with aiohttpFor my production instance it was leaking ~450MiB per dayof `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport``memoryview`, and `managedbuffer` objectsseeaio-libs/aiohttp#7252seepython/cpython#98540
@Dreamsorcerer
Copy link
Contributor

This change makes it unsafe to call.abort() after being closed (which seems to be causing exceptions and severe memory leaks for some aiohttp users in 3.11.1+). We'll obviously add a check to aiohttp, but should.abort() be updated to be safe to call?

@gvanrossum
Copy link
Member

This change makes it unsafe to call.abort() after being closed (which seems to be causing exceptions and severe memory leaks for some aiohttp users in 3.11.1+). We'll obviously add a check to aiohttp, but should.abort() be updated to be safe to call?

Makes sense. Can you send a PR?

balloob pushed a commit to home-assistant/core that referenced this pull requestMay 14, 2023
…93013)* Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.2+There is currently a relatively fast memory leak when usingcpython 3.11.2+ and cleanup_closed with aiohttpFor my production instance it was leaking ~450MiB per dayof `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport``memoryview`, and `managedbuffer` objectsseeaio-libs/aiohttp#7252seepython/cpython#98540* Update homeassistant/helpers/aiohttp_client.py
@Dreamsorcerer
Copy link
Contributor

@gvanrossum#104474

balloob pushed a commit to home-assistant/core that referenced this pull requestMay 14, 2023
…93013)* Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.2+There is currently a relatively fast memory leak when usingcpython 3.11.2+ and cleanup_closed with aiohttpFor my production instance it was leaking ~450MiB per dayof `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport``memoryview`, and `managedbuffer` objectsseeaio-libs/aiohttp#7252seepython/cpython#98540* Update homeassistant/helpers/aiohttp_client.py
teharris1 pushed a commit to teharris1/home-assistant that referenced this pull requestMay 23, 2023
…ome-assistant#93013)* Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.2+There is currently a relatively fast memory leak when usingcpython 3.11.2+ and cleanup_closed with aiohttpFor my production instance it was leaking ~450MiB per dayof `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport``memoryview`, and `managedbuffer` objectsseeaio-libs/aiohttp#7252seepython/cpython#98540* Update homeassistant/helpers/aiohttp_client.py
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@1st11st1Awaiting requested review from 1st1

@asvetlovasvetlovAwaiting requested review from asvetlov

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@kumaraditya303@miss-islington@bedevere-bot@Dreamsorcerer@gvanrossum
[8]ページ先頭
©2009-2025 Movatter.jp