NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

GH-98522: Add version number to code objects, to provide better version numbers for closures and comprehensions.#98525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

markshannon merged 6 commits intopython:mainfromfaster-cpython:code-version

Dec 9, 2022

Merged

GH-98522: Add version number to code objects, to provide better version numbers for closures and comprehensions.#98525

markshannon merged 6 commits intopython:mainfromfaster-cpython:code-version

Dec 9, 2022

Conversation

Copy link

Member

markshannon commentedOct 21, 2022•
edited by bedevere-bot
Loading

Measured performance impactmight be positive but is too close to noise to be meaningful.

Issue:Add a version number to code objects #98522

markshannon added2 commits

October 21, 2022 16:08

Add version number to code object for better versioning of functions.

d1e02c4

Add news

004b132

bedevere-bot added the awaiting core review label

Oct 21, 2022

markshannon changed the title~~Add version number to code objects, to provide better version numbers for closures and comprehensions.~~GH-98522: Add version number to code objects, to provide better version numbers for closures and comprehensions.

Oct 21, 2022

iritkatriel reviewed

Nov 5, 2022

View reviewed changes

Tools/build/deepfreeze.pyShow resolvedHide resolved

Compute initial value of code version during deepfreeze.

46d77fd

bedevere-bot mentioned this pull request

Nov 7, 2022

Add a version number to code objects#98522

Closed

Merge branch 'main' into code-version

9e668c9

brandtbucher self-requested a review

November 18, 2022 21:02

Merge branch 'main' into code-version

ba0b8f4

markshannon requested a review fromiritkatriel

November 29, 2022 11:43

iritkatriel reviewed

Nov 29, 2022

View reviewed changes

Tools/build/deepfreeze.pyShow resolvedHide resolved

iritkatriel reviewed

Nov 29, 2022

View reviewed changes

Include/internal/pycore_code.h

		@@ -472,6 +472,8 @@ typedef struct _PyShimCodeDef {
		extern PyCodeObject *
		_Py_MakeShimCode(const _PyShimCodeDef *code);

		extern uint32_t _Py_next_func_version;

Copy link

Member

iritkatrielNov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a reason why this is called func_version and not code_version? I find it a bit confusing (note that in deepfreeze.py we now have_Py_next_func_version = {next_code_version}).

Copy link

MemberAuthor

markshannonDec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is primarily used as the version for functions.
https://github.com/python/cpython/blob/main/Python/bytecodes.c#L2976
Caching it in the code object is a further optimization.