Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-97850: Deprecatefind_loader andget_loader inpkgutil#98520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedOct 21, 2022•
edited
Loading

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some comments and suggestions on the implementation of this deprecation, based on how we've handled others recently.

Pro tip (since not everyone seems to know this): if you go to theFiles changed tab of this PR, you can apply some or all of the suggestions in one click by clickingAdd to batch on each suggestion you want, and then clickCommit either at the top or on any added suggestion with a descriptive message.

sobolevnand others added2 commitsNovember 9, 2022 16:22
…6coo.rstCo-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@sobolevn
Copy link
MemberAuthor

Thank you for the reviews:@merwok and@CAM-Gerlach
It is much better now. I was not aware of._deprecated helper.

I've also checked thatget_loader does not get 2 warnings (because it is usingfind_loader inside):

>>>importpkgutil>>>pkgutil.get_loader('os')<stdin>:1:DeprecationWarning:'pkgutil.get_loader'isdeprecatedandslatedforremovalinPython3.14;useimportlib.util.find_specinstead<_frozen_importlib_external.SourceFileLoaderobjectat0x1012d55f0>>>>

test_pkgutil tests are also clean, no unwanted warnings. I will look through all logs again when it is completed.

I've also merged one of the@CAM-Gerlach's suggestion, so you get a credit for your awesome proposals! 🤝

CAM-Gerlach reacted with thumbs up emojiCAM-Gerlach reacted with heart emoji

Copy link
Member

@brettcannonbrettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall LGTM, but I think there might be some unnecessary checks in the tests for various module "kinds".

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@CAM-Gerlach
Copy link
Member

I've also merged one of the@CAM-Gerlach's suggestion, so you get a credit for your awesome proposals! handshake

Just FYI, you can apply some or all of them at once by going to theFiles changed tab, clickingAdd to batch on each suggestion and then clicking `Commit (with an appropriate message).

@sobolevn
Copy link
MemberAuthor

@brettcannon I forgot to send the magic phrase!

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

Copy link
Member

@brettcannonbrettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately I just realized that the documentation for pkgutil needs updating to mention the deprecations.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Brett Cannon <brett@python.org>
@sobolevnsobolevn changed the titlegh-97850: Deprecatefind_module andget_module inpkgutilgh-97850: Deprecatefind_loader andget_loader inpkgutilFeb 5, 2023
@sobolevn
Copy link
MemberAuthor

I have made the requested changes; please review again 🙂

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@sobolevn
Copy link
MemberAuthor

Oups, just found out that my push withpkgutil.rst change did not make it into this branch :(

Redid it now, it worked!

hugovk reacted with thumbs up emoji

@brettcannon
Copy link
Member

@sobolevn the changes look good, but now there are unfortunately merge conflicts.

@sobolevn
Copy link
MemberAuthor

Done :)

@brettcannonbrettcannon merged commitd6e83fb intopython:mainMay 3, 2023
@brettcannon
Copy link
Member

Thanks!

@warsaw
Copy link
Member

Thank you for this additional cleanup!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@merwokmerwokmerwok left review comments

@hugovkhugovkhugovk left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments

@brettcannonbrettcannonbrettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@sobolevn@bedevere-bot@CAM-Gerlach@brettcannon@warsaw@merwok@hugovk@arhadthedev
[8]ページ先頭
©2009-2025 Movatter.jp