Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-97514: Don't use Linux abstract sockets for multiprocessing#98501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.
The right people won't see it and it won't blame the right code.
Yhg1s approved these changesOct 20, 2022
Contributor
miss-islington commentedOct 20, 2022
bedevere-bot commentedOct 20, 2022
GH-98502 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 20, 2022
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 20, 2022
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
bedevere-bot commentedOct 20, 2022
GH-98503 is a backport of this pull request to the3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 20, 2022
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
Contributor
miss-islington commentedOct 20, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 20, 2022
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
MemberAuthor
gpshead commentedOct 20, 2022
GH-98504 is the backport of this pull request to the3.9 branch.(miss-islington created the PR but some how fell over applying labels to it and posting this message here) |
miss-islington added a commit that referenced this pull requestOct 20, 2022
…GH-98501) (GH-98503)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>Automerge-Triggered-By: GH:gpshead
miss-islington added a commit that referenced this pull requestOct 20, 2022
…GH-98501) (GH-98502)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>Automerge-Triggered-By: GH:gpshead
pablogsal pushed a commit that referenced this pull requestOct 22, 2022
…GH-98501) (GH-98502)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>Automerge-Triggered-By: GH:gpshead
ambv pushed a commit that referenced this pull requestOct 28, 2022
…H-98501) (#98504)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Linux abstract sockets lack any form of permissions so their use allows any process in the same host-local network namespace (which means any user on the system in many default configurations) to inject code into the process. A "same machine Remote Code Execution RCE" vulnerability.
This removes the default preference for abstract sockets in multiprocessing introduced in Python 3.9+ via
#18866 while fixing#84031.
This issue was reported to the PSRT on 2022-09-07 by Devin Jeanpierre@ssbr from Google.@gpshead requested the CVE.
More good reasoning on why to avoid abstract AF_UNIX sockets on Linux:https://web.archive.org/web/20220107100548/https://utcc.utoronto.ca/~cks/space/blog/linux/SocketAbstractNamespace?showcomments#comments
This is intended for backporting to apply to 3.9 - 3.12.
Urgency: The Release Manager@pablogsal has approved having this in 3.11.0. As the issue is Linux only,there is NO urgent need for new Windows or macOS package builds. So even if a new 3.10.x and 3.9.x release is not officially cut while making it public, this small change is trivially back-ported by all involved Linux Python binary package distributors whom we assume will bevery interested in having it.
PSRT report & discussion:https://mail.python.org/archives/list/psrt@python.org/thread/WMFW2T2I4P3I7SQHYJEBZTSHRVJT44F6/