Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-98393: Update test_os for bytes-like types#98487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Lib/test/test_os.py Outdated
| @@ -3861,17 +3861,17 @@ def test_oserror_filename(self): | |||
| for filenames, func, *func_args in funcs: | |||
| for name in filenames: | |||
| if not isinstance(name, (str, bytes)): | |||
| with self.assertRaises(TypeError): | |||
| func(name, *func_args) | |||
| # don't test TypeError here | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Other types are already well tested in other test methods of test_os.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Then why these filenames are occurred here at first place?bytearray andmemoryview should not be added inself.bytes_filenames.
BTW, does checking conditionsys.platform == "win32" above still have sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I removed bytearray and memoryviews fromself.bytes_filenames (andself.filenames).
I removed the code specific to Windows: let's see how CIs like my updated change :-)
@serhiy-storchaka: Would you mind to review the updated PR? |
Address Serhiy Storchaka's review.
"Tests / Check if generated files are up to date (pull_request)" failed for an unrelated reason: I rebased my PR to see if it helps. |
Thanks for the review@serhiy-storchaka. |
Uh oh!
There was an error while loading.Please reload this page.
Address Serhiy Storchaka's review.