Dec 4, 2022 · Oct 19, 2022 · Oct 19, 2022 · Dec 1, 2022 · Dec 1, 2022 · Dec 3, 2022
diff --git a/Lib/test/test_unittest/test_result.py b/Lib/test/test_unittest/test_result.py
        self.assertEqual(len(dropped), 1)
        self.assertIn("raise self.failureException(msg)", dropped[0])

    def test_addFailure_filter_traceback_frames_chained_exception_cycle(self):
        class Foo(unittest.TestCase):
            def test_1(self):
                pass

        def get_exc_info():
            try:
                # Create two directionally opposed cycles
                # __cause__ in one direction, __context__ in the other
                # Only one is needed since they serve the same role in _clean_tracebacks()
                # But this way we cover both possibilities if the code changes
                A, B, C = Exception("A"), Exception("B"), Exception("C")
                edges = [(C, B), (B, A), (A, C)]
                for ex1, ex2 in edges:
                    ex1.__cause__ = ex2
                    ex2.__context__ = ex1
                raise C
            except:
                return sys.exc_info()

        exc_info_tuple = get_exc_info()

        test = Foo('test_1')
        result = unittest.TestResult()
        result.startTest(test)
        result.addFailure(test, exc_info_tuple)
        result.stopTest(test)

        formatted_exc = result.failures[0][1]
        self.assertEqual(formatted_exc.count("Exception: A\n"), 1)
        self.assertEqual(formatted_exc.count("Exception: B\n"), 1)
        self.assertEqual(formatted_exc.count("Exception: C\n"), 1)

    # "addError(test, err)"
    # ...
    # "Called when the test case test raises an unexpected exception err
diff --git a/Lib/unittest/result.py b/Lib/unittest/result.py
        ret = None
        first = True
        excs = [(exctype, value, tb)]
        seen = {id(value)}  # Handle loops in __cause__ or __context__.
        while excs:
            (exctype, value, tb) = excs.pop()
            # Skip test runner traceback levels

            if value is not None:
                for c in (value.__cause__, value.__context__):
                    if c is not None andc isnotvalue:
                    if c is not None andid(c)notin seen:
                        excs.append((type(c), c, c.__traceback__))
                        seen.add(id(c))
        return ret

    def _is_relevant_tb_level(self, tb):
Original file line number	Diff line number	Diff line change
Expand Up		@@ -275,6 +275,39 @@ def get_exc_info():
		self.assertEqual(len(dropped), 1)
		self.assertIn("raise self.failureException(msg)", dropped[0])

		def test_addFailure_filter_traceback_frames_chained_exception_cycle(self):
		class Foo(unittest.TestCase):
		def test_1(self):
		pass

		def get_exc_info():
AlexTate marked this conversation as resolved. Show resolvedHide resolved
		try:
		# Create two directionally opposed cycles
		# __cause__ in one direction, __context__ in the other
		# Only one is needed since they serve the same role in _clean_tracebacks()
		# But this way we cover both possibilities if the code changes
AlexTate marked this conversation as resolved. Show resolvedHide resolved
		A, B, C = Exception("A"), Exception("B"), Exception("C")
		edges = [(C, B), (B, A), (A, C)]
		for ex1, ex2 in edges:
		ex1.__cause__ = ex2
		ex2.__context__ = ex1
		raise C
		except:
		return sys.exc_info()

		exc_info_tuple = get_exc_info()

		test = Foo('test_1')
		result = unittest.TestResult()
		result.startTest(test)
		result.addFailure(test, exc_info_tuple)
		result.stopTest(test)

		formatted_exc = result.failures[0][1]
		self.assertEqual(formatted_exc.count("Exception: A\n"), 1)
		self.assertEqual(formatted_exc.count("Exception: B\n"), 1)
		self.assertEqual(formatted_exc.count("Exception: C\n"), 1)

		# "addError(test, err)"
		# ...
		# "Called when the test case test raises an unexpected exception err
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -196,6 +196,7 @@ def _clean_tracebacks(self, exctype, value, tb, test):
		ret = None
		first = True
		excs = [(exctype, value, tb)]
		seen = {id(value)} # Handle loops in __cause__ or __context__.
AlexTate marked this conversation as resolved. Show resolvedHide resolved
		while excs:
		(exctype, value, tb) = excs.pop()
		# Skip test runner traceback levels
Expand All		@@ -214,8 +215,9 @@ def _clean_tracebacks(self, exctype, value, tb, test):

		if value is not None:
		for c in (value.__cause__, value.__context__):
		if c is not None andc isnotvalue:
		if c is not None andid(c)notin seen:
		excs.append((type(c), c, c.__traceback__))
		seen.add(id(c))
		return ret

		def _is_relevant_tb_level(self, tb):
Expand Down