NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.4k

gh-98421: Clean Up PyObject_Print#98422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

encukou merged 2 commits intopython:mainfromMonadChains:gh-98421/remove-dead-code-from-pyobject_print

Oct 20, 2022

Merged

gh-98421: Clean Up PyObject_Print#98422

encukou merged 2 commits intopython:mainfromMonadChains:gh-98421/remove-dead-code-from-pyobject_print

Oct 20, 2022

Conversation

Copy link

Contributor

MonadChains commentedOct 18, 2022•
edited by bedevere-bot
Loading

See#98421 for explaination.

Issue:Remove Dead Code in PyObject_Print #98421

clean up PyObject_Print

db0181e

bedevere-bot added the awaiting review label

Oct 18, 2022

JelleZijlstra added the skip news label

Oct 19, 2022

JelleZijlstra reviewed

Oct 19, 2022

View reviewed changes

Objects/object.c OutdatedShow resolvedHide resolved

encukou reviewed

Oct 19, 2022

View reviewed changes

Objects/object.c OutdatedShow resolvedHide resolved

address reviews

9192ae2

encukou approved these changes

Oct 20, 2022

View reviewed changes

Copy link

Member

encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

bedevere-bot added awaiting merge and removed awaiting review labels

Oct 20, 2022

Copy link

Member

encukou commentedOct 20, 2022

Jelle, did you want to take another look?

JelleZijlstra approved these changes

Oct 20, 2022

View reviewed changes

encukou merged commitc60b3b3 intopython:main

Oct 20, 2022

bedevere-bot removed the awaiting merge label

Oct 20, 2022

carljm added a commit to carljm/cpython that referenced this pull request

Oct 20, 2022

Merge branch 'main' into typewatch

8bba5da

* main: (40 commits)pythongh-98461: Fix source location in comprehensions bytecode (pythonGH-98464)pythongh-98421: Clean Up PyObject_Print (pythonGH-98422)pythongh-98360: multiprocessing now spawns children on Windows with correct argv[0] in virtual environments (pythonGH-98462)  CODEOWNERS: Become a typing code owner (python#98480)  [doc] Improve logging cookbook example. (pythonGH-98481)  Add more tkinter.Canvas tests (pythonGH-98475)pythongh-95023: Added os.setns and os.unshare functions (python#95046)pythonGH-98363: Presize the list for batched() (pythonGH-98419)pythongh-98374: Suppress ImportError for invalid query for help() command. (pythongh-98450)  typing tests: `_overload_dummy` raises `NotImplementedError`, not `RuntimeError` (python#98351)pythongh-98354: Add unicode check for 'name' attribute in _imp_create_builtin (pythonGH-98412)pythongh-98257: Make _PyEval_SetTrace() reentrant (python#98258)pythongh-98414: py.exe launcher does not use defaults for -V:company/ option (pythonGH-98460)pythongh-98417: Store int_max_str_digits on the Interpreter State (pythonGH-98418)  Doc: Remove title text from internal links (python#98409)  [doc] Refresh the venv introduction documentation, and correct the statement about VIRTUAL_ENV (pythonGH-98350)  Docs: Bump sphinx-lint and fix unbalanced inline literal markup (python#98441)pythongh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) (pythonGH-93231)pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `_test_multiprocessing.py` (pythonGH-93233)pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_py_compile.py` (pythonGH-93235)  ...