Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-97527: IDLE - fix buggy macosx patch#98313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
python#97530 fixed IDLE tests possibly crashing on a Mac without a GUI.But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, andMicrosoft Python 3.10.2288.0 when test/* is not installed.After this patch, test.* is only imported when testing on Mac.
Contributor
miss-islington commentedOct 16, 2022
Thanks@terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 16, 2022
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, andMicrosoft Python 3.10.2288.0 when test/* is not installed.After this patch, test.* is only imported when testing on Mac.(cherry picked from commit35fa5d5)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
bedevere-bot commentedOct 16, 2022
GH-98329 is a backport of this pull request to the3.11 branch. |
bedevere-bot commentedOct 16, 2022
GH-98330 is a backport of this pull request to the3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 16, 2022
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, andMicrosoft Python 3.10.2288.0 when test/* is not installed.After this patch, test.* is only imported when testing on Mac.(cherry picked from commit35fa5d5)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
MemberAuthor
terryjreedy commentedOct 16, 2022
The code for test.support.resource raises ResourceDenied(reason) on failure. |
Member
arhadthedev commentedOct 16, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Links for historical purposes: |
Contributor
miss-islington commentedOct 16, 2022
Thanks@terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 16, 2022
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, andMicrosoft Python 3.10.2288.0 when test/* is not installed.After this patch, test.* is only imported when testing on Mac.(cherry picked from commit35fa5d5)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull requestOct 16, 2022
GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, andMicrosoft Python 3.10.2288.0 when test/* is not installed.After this patch, test.* is only imported when testing on Mac.(cherry picked from commit35fa5d5)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
MemberAuthor
terryjreedy commentedOct 16, 2022
3.11 backport originally failed due to randon failure in a non-idle test. Re-adding backport label triggered retesting in original backport PR. |
miss-islington added a commit that referenced this pull requestOct 16, 2022
GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, andMicrosoft Python 3.10.2288.0 when test/* is not installed.After this patch, test.* is only imported when testing on Mac.(cherry picked from commit35fa5d5)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
carljm added a commit to carljm/cpython that referenced this pull requestOct 17, 2022
* main: (31 commits)pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345)pythongh-95914: Add What's New item describing PEP 670 changes (python#98315) Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358)pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316)pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333)pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001)pythongh-97669: Create Tools/build/ directory (python#97963)pythongh-95534: Improve gzip reading speed by 10% (python#97664)pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344)pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336)pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929)pythongh-85525: Remove extra row in doc (python#98337)pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457)pythongh-97527: IDLE - fix buggy macosx patch (python#98313)pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319)pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158)pythonGH-94597: Deprecate child watcher getters and setters (python#98215)pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255) Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294) [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290) ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
#97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac.