Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Mark all targets inDoc/Makefile asPHONY#98189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JulienPalard merged 1 commit intopython:mainfromsobolevn:patch-12
Oct 12, 2022

Conversation

@sobolevn
Copy link
Member

Some of them were missing froPHONY list. Some of them were in correct order.
Now order ofPHONY and order of definitions match.

Docs onPHONY:https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html

@JulienPalard
Copy link
Member

Thanks! We should keep a better eye on this one ☺

@zware
Copy link
Member

I've found it easier to keep track of.PHONY targets by doing something like:

.PHONY: helphelp:@echo ....PHONY: buildbuild:....PHONY: htmlhtml: BUILDER = htmlhtml: build@echo ...

It's more verbose, and I am not certain that allmakes will handle it correctly, but I've found this style much easier to keep up to date. Perhaps a consideration for the future?

hugovk reacted with thumbs up emoji

@JulienPalard
Copy link
Member

Perhaps, yes.

Having the.PHONY near the rule is what I'm acustomed to do too, but I've seen many makefiles with all PHONY's on the same line like here.

I never heard about compatibility issues (but I'm only using GNU make so ... I'm not a reference).

@sobolevn
Copy link
MemberAuthor

I am also using.PHONY on target level, example:https://github.com/sobolevn/git-secret/blob/master/Makefile#L12

I never got any complaints :)

@sobolevn
Copy link
MemberAuthor

Thanks for the quick merge! 👍

@hugovk
Copy link
Member

I've found it easier to keep track of.PHONY targets by doing something like:

.PHONY: helphelp:@echo ....PHONY: buildbuild:....PHONY: htmlhtml: BUILDER = htmlhtml: build@echo ...

It's more verbose, and I am not certain that allmakes will handle it correctly, but I've found this style much easier to keep up to date. Perhaps a consideration for the future?

Agreed, I expect it will happen again because it's normal to copy/paste a target and forget (or not know) to update the.PHONY line right at the top.

I was making some other fixes to the Makefile, so included this too:#98266

carljm added a commit to carljm/cpython that referenced this pull requestOct 14, 2022
* main: (38 commits)pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259)  Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399)  bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596)pythongh-98178: syslog() is not thread-safe on macOS (python#98213)  Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189)pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025)pythongh-96265: Formatting changes for faq/general (python#98129)  tutorial: remove "with single quotes" (python#98204)pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214)  signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217)pythongh-97669: Fix test_tools reference leak (python#98216)pythongh-97669: Create Tools/patchcheck/ directory (python#98186)pythongh-65046: Link to logging cookbook from asyncio docs (python#98207)  Formatting fixes in contextlib docs (python#98111)pythongh-95276: Add callable entry to the glossary (python#95738)pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144)  Fix some incorrect indentation around the main switch (python#98177)pythongh-98172: Fix formatting in `except*` docs (python#98173)pythongh-97982: Remove asciilib_count() (python#98164)pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181)  ...
carljm added a commit to carljm/cpython that referenced this pull requestOct 14, 2022
* main: (37 commits)pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259)  Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399)  bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596)pythongh-98178: syslog() is not thread-safe on macOS (python#98213)  Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189)pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025)pythongh-96265: Formatting changes for faq/general (python#98129)  tutorial: remove "with single quotes" (python#98204)pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214)  signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217)pythongh-97669: Fix test_tools reference leak (python#98216)pythongh-97669: Create Tools/patchcheck/ directory (python#98186)pythongh-65046: Link to logging cookbook from asyncio docs (python#98207)  Formatting fixes in contextlib docs (python#98111)pythongh-95276: Add callable entry to the glossary (python#95738)pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144)  Fix some incorrect indentation around the main switch (python#98177)pythongh-98172: Fix formatting in `except*` docs (python#98173)pythongh-97982: Remove asciilib_count() (python#98164)pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JulienPalardJulienPalardAwaiting requested review from JulienPalard

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@JulienPalard@zware@hugovk@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp