Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-90535: Warn of deprecation of intervals other than 1 withwhen='MIDNIGHT'#98099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
when=='MIDNIGHT'when=='MIDNIGHT'when='MIDNIGHT'| self.fn,encoding="utf-8",when='MIDNIGHT',interval=2,backupCount=0, | ||
| utc=True) | ||
| rh.close() | ||
| ifw: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you want the test to pass if no warning is raised? If not then in the above I would force deprecations on as exceptions viawarnings.simplefilter("error").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point. Thanks for the review, Brett.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not useassertWarns()?
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I do not think that this change is needed. What if you want to roll over at 4:00 every second night? What are the alternatives?
| importqueue | ||
| importthreading | ||
| importcopy | ||
| importwarnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is better to defer thewarnings module import until it is needed (which never happen in normal case).
| self.fn,encoding="utf-8",when='MIDNIGHT',interval=2,backupCount=0, | ||
| utc=True) | ||
| rh.close() | ||
| ifw: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not useassertWarns()?
serhiy-storchaka commentedMar 13, 2024
#116220 is an alternate solution, which fixes support of intervals>1 instead of deprecating it for when='MIDNIGHT' and when='Wx'. |
serhiy-storchaka commentedMar 18, 2024
I guess it can be closed now. |
Uh oh!
There was an error while loading.Please reload this page.