Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-98030: socket: add missing TCP socket options#98031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 2 commits intopython:mainfrommatttbe:fix-issue-98030
Dec 8, 2022

Conversation

@matttbe
Copy link
Contributor

@matttbematttbe commentedOct 7, 2022•
edited by bedevere-bot
Loading

A few TCP socket options have been added to the Linux kernel these last few years.

This commit adds all the ones available in Linux 6.0:

https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91

While at it, theTCP_FASTOPEN option has been moved lower in the list just to keep the same order as intcp.h to ease future synchronisations.

Please note that I initially wanted to getsocket.TCP_FASTOPEN_CONNECT. I was going to add only this one but while at it, here are all the missing ones.

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@matttbematttbeforce-pushed thefix-issue-98030 branch 2 times, most recently from19f8cc6 to90f954bCompareOctober 10, 2022 09:38
@gpsheadgpshead self-assigned thisOct 23, 2022
@gpsheadgpshead self-requested a reviewOctober 23, 2022 19:29
A few TCP socket options have been added to the Linux kernel these lastfew years.This commit adds all the ones available in Linux 6.0:https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91While at it, the TCP_FASTOPEN option has been moved lower in the listjust to keep the same order as in tcp.h to ease future synchronisations.Please note that I initially wanted to get socket.TCP_FASTOPEN_CONNECT.I was going to add only this one but while at it, here are all themissing ones.Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
@netlify
Copy link

netlifybot commentedDec 7, 2022•
edited
Loading

✅ Deploy Preview forpython-cpython-preview canceled.

NameLink
🔨 Latest commite88ecc3
🔍 Latest deploy loghttps://app.netlify.com/sites/python-cpython-preview/deploys/6390bacb860fca000840639c

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
@matttbe
Copy link
ContributorAuthor

Hi@gpshead,

Thank you for the review! I'm sorry for the delay, I missed the notification when I was on holiday.

I just listed all new constants in the doc as requested. Feel free to tell me if it is not what you had in mind!

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM Raspbian 3.x has failed when building commitcce8362.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/3098) and take a look at the build logs.
  4. Check if the failure is related to this commit (cce8362) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/3098

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

  • test_venv: 10 min 30 sec
  • test_largefile: 6 min 5 sec
  • test_asyncio: 3 min 50 sec
  • test_multiprocessing_spawn: 3 min 47 sec
  • test_concurrent_futures: 2 min 58 sec
  • test_cppext: 2 min 54 sec
  • test_tools: 2 min 29 sec
  • test_tokenize: 2 min 17 sec
  • test_multiprocessing_forkserver: 2 min 1 sec
  • test_gdb: 1 min 46 sec

1 test altered the execution environment:
test_asyncio

21 tests skipped:
test_check_c_globals test_devpoll test_idle test_ioctl test_kqueue
test_launcher test_msilib test_peg_generator test_perf_profiler
test_startfile test_tcl test_tix test_tkinter test_ttk
test_ttk_textonly test_turtle test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

Total duration: 28 min 25 sec

Click to see traceback logs
remote:Enumerating objects: 12, done.remote:Counting objects:   9% (1/11)remote:Counting objects:  18% (2/11)remote:Counting objects:  27% (3/11)remote:Counting objects:  36% (4/11)remote:Counting objects:  45% (5/11)remote:Counting objects:  54% (6/11)remote:Counting objects:  63% (7/11)remote:Counting objects:  72% (8/11)remote:Counting objects:  81% (9/11)remote:Counting objects:  90% (10/11)remote:Counting objects: 100% (11/11)remote:Counting objects: 100% (11/11), done.remote:Compressing objects:  14% (1/7)remote:Compressing objects:  28% (2/7)remote:Compressing objects:  42% (3/7)remote:Compressing objects:  57% (4/7)remote:Compressing objects:  71% (5/7)remote:Compressing objects:  85% (6/7)remote:Compressing objects: 100% (7/7)remote:Compressing objects: 100% (7/7), done.remote:Total 12 (delta 4), reused 4 (delta 4), pack-reused 1From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to 'cce836296016463032495c6ca739ab469ed13d3c'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at cce8362960 gh-98030: socket: add missing TCP socket options (#98031)Switched to and reset branch 'main'Objects/obmalloc.c:776:1: warning: ‘always_inline’ function might not be inlinable [-Wattributes]  776 | arena_map_get(pymem_block *p, int create)|^~~~~~~~~~~~~make:*** [Makefile:1889: buildbottest] Error 3

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

Assignees

@gpsheadgpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matttbe@bedevere-bot@gpshead
[8]ページ先頭
©2009-2025 Movatter.jp