Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Fix memory leaks in test_capi#98017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@kumaraditya303 ➜ /workspaces/cpython (fixleak) $ ./python -m test test_capi -R 3:30:00:00 load avg: 0.98 Run tests sequentially0:00:00 load avg: 0.98 [1/1] test_capibeginning 6 repetitions123456......test_capi passed in 38.6 sec== Tests result: SUCCESS ==1 test OK.Total duration: 38.6 secTests result: SUCCESS |
kumaraditya303 approved these changesOct 7, 2022
@vstinner: This PR fixes ref leak on main. Currently all refleak buildbots are failing. Seehttps://buildbot.python.org/all/#/release_status |
You may want to use |
mpage pushed a commit to mpage/cpython that referenced this pull requestOct 11, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These memory leaks were recently introduced in#31787. Not sure if this fix qualifies as "trivial" or requires an issue also.
Before this fix,
./python -m test test_capi -R 3:3reports a memory leak; after this fix it passes.