Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Auto-cancel old builds when new commit pushed to branch#98009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ezio-melotti merged 3 commits intopython:mainfromhugovk:cancel-old-builds
Oct 8, 2022

Conversation

@hugovk
Copy link
Member

Let's use GitHub Actions'concurrency to cancel outdated runs.

So if you push more than once to a given branch, it auto-cancels runs for older commits to make way for the newest commit to run.

This will help when there's a large backlog of builds and we're hitting limits.

Docs:

Is an issue needed?

noamcohen97 reacted with thumbs up emoji
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@ezio-melotti
Copy link
Member

I'm going to merge this and see what happens. If everything works well I will backport it.

@ezio-melottiezio-melotti merged commit75751f4 intopython:mainOct 8, 2022
@ezio-melotti
Copy link
Member

This seems to be working well:
image

@ezio-melottiezio-melotti added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsOct 8, 2022
@miss-islington
Copy link
Contributor

Thanks@hugovk for the PR, and@ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@hugovk for the PR, and@ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@hugovk and@ezio-melotti, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.11

@miss-islington
Copy link
Contributor

Sorry@hugovk and@ezio-melotti, I had trouble checking out the3.10 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.10

@ezio-melotti
Copy link
Member

(If we backport#92999 the conflict should go away and make the workflow files more consistent between branches, so I'm waiting for that before backporting this.)

hugovk reacted with thumbs up emoji

@hugovkhugovk deleted the cancel-old-builds branchOctober 9, 2022 06:24
carljm added a commit to carljm/cpython that referenced this pull requestOct 9, 2022
* main:  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)  Auto-cancel old builds when new commit pushed to branch (python#98009)pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull requestOct 9, 2022
* main: (5519 commits)  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)  Auto-cancel old builds when new commit pushed to branch (python#98009)pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)pythongh-68686: Retire eptag ptag scripts (python#98064)pythongh-97922: Run the GC only on eval breaker (python#97920)  GitHub Workflows security hardening (python#96492)  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)pythongh-97913 Docs: Add walrus operator to the index (python#97921)  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)pythongh-97822: Fix http.server documentation reference to test() function (python#98027)pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)pythongh-57179: Add note on symlinks for os.walk (python#94799)pythongh-94808: Fix regex on exotic platforms (python#98036)pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)  ...
@ezio-melottiezio-melotti added needs backport to 3.10only security fixes and removed needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsOct 10, 2022
@ezio-melottiezio-melotti added the needs backport to 3.11only security fixes labelOct 10, 2022
@miss-islington
Copy link
Contributor

Thanks@hugovk for the PR, and@ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@hugovk for the PR, and@ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@hugovk and@ezio-melotti, I had trouble checking out the3.10 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 10, 2022
* Auto-cancel old builds when new commit pushed to branch* Add a fallbackCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Use the same group for all workflows.Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>(cherry picked from commit75751f4)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98162 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelOct 10, 2022
@bedevere-bot
Copy link

GH-98163 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 10, 2022
miss-islington added a commit that referenced this pull requestOct 10, 2022
* Auto-cancel old builds when new commit pushed to branch* Add a fallbackCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Use the same group for all workflows.Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>(cherry picked from commit75751f4)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ezio-melotti added a commit that referenced this pull requestOct 10, 2022
) (#98163)* Auto-cancel old builds when new commit pushed to branch* Add a fallbackCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Use the same group for all workflows.Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>(cherry picked from commit75751f4)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@ezio-melotti
Copy link
Member

Backported 🥳

hugovk reacted with hooray emoji

mpage pushed a commit to mpage/cpython that referenced this pull requestOct 11, 2022
* Auto-cancel old builds when new commit pushed to branch* Add a fallbackCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Use the same group for all workflows.Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ambvambvambv left review comments

@sobolevnsobolevnsobolevn left review comments

@ezio-melottiezio-melottiezio-melotti approved these changes

Assignees

@ezio-melottiezio-melotti

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hugovk@ezio-melotti@miss-islington@bedevere-bot@ambv@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp