NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-97997: Add col_offset field to tokenizer and use that for AST nodes#98000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pablogsal merged 5 commits intopython:mainfromlysnikolaou:tokenizer-col-offset-field

Oct 7, 2022

Merged

gh-97997: Add col_offset field to tokenizer and use that for AST nodes#98000

pablogsal merged 5 commits intopython:mainfromlysnikolaou:tokenizer-col-offset-field

Oct 7, 2022

Conversation

Copy link

Member

lysnikolaou commentedOct 6, 2022•
edited by bedevere-bot
Loading

Issue:Include column offset information in the tokenizer #97997

pythongh-97997: Add col_offset field to tokenizer and use that for AS…

faefec5

…T nodes

lysnikolaou requested a review frompablogsal as acode owner

October 6, 2022 23:11

bedevere-bot added the awaiting core review label

Oct 6, 2022

📜🤖 Added by blurb_it.

d3f852c

lysnikolaou added the sprint label

Oct 6, 2022

lysnikolaou added3 commits

October 6, 2022 17:18

Remove unnecessary assignment of starting_col_offset

5c47419

Add comment

4796a40

Address feedback; add macro to advance new line

d128a37

lysnikolaou linked an issue

Oct 7, 2022

that may beclosed by this pull request

Include column offset information in the tokenizer#97997

Closed

pablogsal approved these changes

Oct 7, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Oct 7, 2022

pablogsal merged commit3de08ce intopython:main

Oct 7, 2022

bedevere-bot removed the awaiting merge label

Oct 7, 2022

lysnikolaou mentioned this pull request

Oct 7, 2022

Use new tokenizer column offset to fix fstring ast locationswe-like-parsers/cpython#195

Merged

carljm added a commit to carljm/cpython that referenced this pull request

Oct 8, 2022

Merge branch 'main' into typewatch

27a4980

* main: (38 commits)pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)pythongh-57179: Add note on symlinks for os.walk (python#94799)pythongh-94808: Fix regex on exotic platforms (python#98036)pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347)pythongh-61105: Add default param, note on using cookiejar subclass (python#95427)pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271)pythongh-96073: fix backticks in NEWS entry (pythonGH-98056)pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051)pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000)pythonGH-88968: Reject socket that is already used as a transport (python#98010)pythongh-96346: Use double caching for re._compile() (python#96347)pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699)pythongh-96265: Fix some formatting in faq/design.rst (python#96924)pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840)pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934)pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940)pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957)pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039)  ...