Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-90985: Revert "Deprecate passing a message into cancel()"#97999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Reason: we were too hasty in deprecating this.We shouldn't deprecate it before we have a replacement.
JelleZijlstra approved these changesOct 7, 2022
Thanks@gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedOct 7, 2022
GH-98006 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 7, 2022
…ythonGH-97999)Reason: we were too hasty in deprecating this.We shouldn't deprecate it before we have a replacement.(cherry picked from commit09de8d7)Co-authored-by: Guido van Rossum <guido@python.org>
1st1 reviewedOct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
miss-islington added a commit that referenced this pull requestOct 7, 2022
carljm added a commit to carljm/cpython that referenced this pull requestOct 8, 2022
* main:pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005) Docs: Fix backtick errors found by sphinx-lint (python#97998)pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898) Remove extra spaces in custom openSSL documentation. (python#93568)pythonGH-90985: Revert "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull requestOct 11, 2022
…ython#97999)Reason: we were too hasty in deprecating this.We shouldn't deprecate it before we have a replacement.
pablogsal pushed a commit that referenced this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.