Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-97943: PyFunction_GetAnnotations should return a borrowed reference.#97949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ference.It was returning a new reference, which isn't how it used to work,and isn't how it's documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know it's shocking, but@larryhastings is right! Itisdocumented to return a borrowed reference, and the implementation should match the documentation.
bedevere-bot commentedOct 6, 2022
🤖 New build scheduled with the buildbot fleet by@pablogsal for commitd46f37e 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Thanks@larryhastings for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedOct 6, 2022
GH-97985 is a backport of this pull request to the3.11 branch. |
Thanks@larryhastings for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…ference. (pythonGH-97949)(cherry picked from commit6bfb0be)Co-authored-by: larryhastings <larry@hastings.org>
…ference. (pythonGH-97949)(cherry picked from commit6bfb0be)Co-authored-by: larryhastings <larry@hastings.org>
Thanks@larryhastings for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
…ference. (pythonGH-97949)(cherry picked from commit6bfb0be)Co-authored-by: larryhastings <larry@hastings.org>
bedevere-bot commentedOct 6, 2022
GH-97989 is a backport of this pull request to the3.10 branch. |
* main:fixespythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992)pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974)pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)pythongh-86482: Document assignment expression need for ()s (python#23291)pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
* main:pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996)pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984)fixespythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992)pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974)pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)pythongh-86482: Document assignment expression need for ()s (python#23291)pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
Uh oh!
There was an error while loading.Please reload this page.
It was returning a new reference, which isn't how it used to work, and isn't how it's documented.