Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.11] gh-91539: improve performance of get_proxies_environment (GH-91566)#97918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…nGH-91566)* improve performance of get_proxies_environment when there are many environment variables* 📜🤖 Added by blurb_it.* fix case of short env name* fix formatting* fix whitespace* whitespace* Update Lib/urllib/request.pyCo-authored-by: Carl Meyer <carl@oddbird.net>* Update Lib/urllib/request.pyCo-authored-by: Carl Meyer <carl@oddbird.net>* Update Lib/urllib/request.pyCo-authored-by: Carl Meyer <carl@oddbird.net>* Update Lib/urllib/request.pyCo-authored-by: Carl Meyer <carl@oddbird.net>* whitespace* Update Misc/NEWS.d/next/Library/2022-04-15-11-29-38.gh-issue-91539.7WgVuA.rstCo-authored-by: Carl Meyer <carl@oddbird.net>* Update Lib/urllib/request.pyCo-authored-by: Carl Meyer <carl@oddbird.net>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Carl Meyer <carl@oddbird.net>(cherry picked from commitaeb28f5)Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Sorry, I can't merge this PR. Reason: |
This is a perf optimization, currently we're accepting changes for 3.11.1+ which are bug fixes only. Therefore, this change cannot be included in 3.11. |
FrederikP commentedMar 7, 2023
I was wondering whether this will be merged at some point? It seems to be included in latest python 3.10 but not latest 3.11, if I saw it correctly. |
so sad this fix was merged in master and merged in 3.10 but the merged in 3.11 was blocked for no reason :( :( :(
|
Uh oh!
There was an error while loading.Please reload this page.
improve performance of get_proxies_environment when there are many environment variables
📜🤖 Added by blurb_it.
fix case of short env name
fix formatting
fix whitespace
whitespace
Update Lib/urllib/request.py
Co-authored-by: Carl Meyercarl@oddbird.net
Co-authored-by: Carl Meyercarl@oddbird.net
Co-authored-by: Carl Meyercarl@oddbird.net
Co-authored-by: Carl Meyercarl@oddbird.net
whitespace
Update Misc/NEWS.d/next/Library/2022-04-15-11-29-38.gh-issue-91539.7WgVuA.rst
Co-authored-by: Carl Meyercarl@oddbird.net
Co-authored-by: Carl Meyercarl@oddbird.net
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Carl Meyercarl@oddbird.net
(cherry picked from commitaeb28f5)
Co-authored-by: Pieter Eendebakpieter.eendebak@gmail.com