The break is caused byasync-isation of a few tests inclass StreamTests2(test_utils.TestCase) not designed for this. Since they happen to be grouped in the end of a file, it's easier to group them under an unplannedclass NewStreamTests2(unittest.IsolatedAsyncioTestCase) and make three in-between testsasync too rather that partially roll the changes back.

Thanks to@kumaraditya303 fornoticing the issue.

Closesgh-97894.

Issue:Replace use oftest.test_asyncio.utils.TestCase withunittest.IsolatedAsyncioTestCase #93357

Port test cases to IsolatedAsyncioTestCase, part 2

79505df

arhadthedev requested review from1st1,asvetlov andgvanrossum ascode owners

October 5, 2022 05:54

bedevere-bot added awaiting review testsTests in the Lib/test dir labels

Oct 5, 2022

kumaraditya303 added topic-asyncio skip news labels

Oct 5, 2022

arhadthedev mentioned this pull request

Oct 5, 2022

gh-93357: Lay the foundation for further work inasyncio.test_streams: port server cases to IsolatedAsyncioTestCase#93369

Merged

arhadthedev marked this pull request as draft

October 5, 2022 06:20

arhadthedev added2 commits

October 5, 2022 10:22

Remove self.loop.set_exception_handler

a46c222

Another fix

ee7e966

Copy link

MemberAuthor

arhadthedev commentedOct 5, 2022

Retriggering the stuck checks.

arhadthedev closed this

Oct 5, 2022

arhadthedev reopened this

Oct 5, 2022

arhadthedev added3 commits

October 5, 2022 10:57

Fix a misuse of async with

bc21d76

Remove more asyncio.open_connection()

87e841c

Return an assignment to data

7b8caca

Copy link

Member

sobolevn commentedOct 5, 2022•
edited
Loading

Please, feel free to ping me when ready. I will run buildbot tests for you.

Copy link

MemberAuthor

arhadthedev commentedOct 5, 2022

@sobolevn Pinging since the tests are done.

arhadthedev marked this pull request as ready for review

October 5, 2022 08:49

sobolevn added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Oct 5, 2022

Copy link

bedevere-bot commentedOct 5, 2022

🤖 New build scheduled with the buildbot fleet by@sobolevn for commit7b8caca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Oct 5, 2022

arhadthedev mentioned this pull request

Oct 5, 2022

test_asyncio failures in the "Ubuntu with SSL" tests#97894

Closed

gvanrossum approved these changes

Oct 5, 2022

View reviewed changes

Copy link

Member

gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, this looks good. I'll merge. Thanks for the quick fix!

gvanrossum merged commit09aea94 intopython:main

Oct 5, 2022

arhadthedev deleted the teststreams-utilsTestCase-servers-2 branch

October 5, 2022 14:39

bedevere-bot removed the awaiting review label

Oct 5, 2022

arhadthedev mentioned this pull request

Oct 6, 2022

Replace use oftest.test_asyncio.utils.TestCase withunittest.IsolatedAsyncioTestCase#93357

Closed

21 tasks

carljm added a commit to carljm/cpython that referenced this pull request

Oct 6, 2022

Merge branch 'main' into dictwatch

4bb5d9d

* main: (66 commits)pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)  docs(typing): add "see PEP 675" to LiteralString (python#97926)pythongh-97850: Remove all known instances of module_repr() (python#97876)  I changed my surname early this year (python#96671)pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)pythongh-91539: improve performance of get_proxies_environment  (python#91566)  build(deps): bump actions/stale from 5 to 6 (python#97701)pythonGH-95172 Make the same version `versionadded` oneline (python#95172)pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383)pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759)pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251)pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662)pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644)pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756)pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778)pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826)  Add re.VERBOSE flag documentation example (python#97678)  ...

arhadthedev added a commit to arhadthedev/cpython that referenced this pull request

Oct 7, 2022

Revert "pythongh-93357: Port test cases to IsolatedAsyncioTestCase, p…

3713915

…art 2 (python#97896)"This reverts commit09aea94.

arhadthedev mentioned this pull request

Oct 7, 2022

gh-97983: Revert "Lay the foundation for further work in asyncio.test_streams: port server cases to IsolatedAsyncioTestCase"#98015

Merged

gvanrossum pushed a commit that referenced this pull request

Oct 7, 2022

gh-97983: Revert "Lay the foundation for further work in asyncio.test…

f99bb20

…_streams: port server cases to IsolatedAsyncioTestCase" (#98015)This PR revertsgh-93369 andgh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods.The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first.I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits.Affected issue:gh-93357.First reported in#97940 (comment).* Revert "gh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (#97896)"This reverts commit09aea94.* Revert "gh-93357: Start porting asyncio server test cases to IsolatedAsyncioTestCase (#93369)"This reverts commitce8fc18.

arhadthedev mentioned this pull request

Oct 9, 2022

Fix a bunch of failing testsarhadthedev/cpython#11

Open

mpage pushed a commit to mpage/cpython that referenced this pull request

Oct 11, 2022

pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (p…

2d20cf5

…ython#97896)This fixes the buildbots.

mpage pushed a commit to mpage/cpython that referenced this pull request

Oct 11, 2022

pythongh-97983: Revert "Lay the foundation for further work in asynci…

e75ada1

…o.test_streams: port server cases to IsolatedAsyncioTestCase" (python#98015)This PR revertspythongh-93369 andpythongh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods.The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first.I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits.Affected issue:pythongh-93357.First reported inpython#97940 (comment).* Revert "pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)"This reverts commit09aea94.* Revert "pythongh-93357: Start porting asyncio server test cases to IsolatedAsyncioTestCase (python#93369)"This reverts commitce8fc18.