Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-97740: Fix bang in Sphinx C domain ref target syntax#97741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ce7fc52 toedda9ddCompare33 tasks
AA-Turner approved these changesOct 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
A
ezio-melotti approved these changesOct 3, 2022
Thanks@CAM-Gerlach for the PR, and@ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commentedOct 3, 2022
GH-97748 is a backport of this pull request to the3.11 branch. |
bedevere-bot commentedOct 3, 2022
GH-97749 is a backport of this pull request to the3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 3, 2022
…GH-97741)*pythongh-97740: Fix bang in Sphinx C domain ref target syntaxCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>* Add NEWS entry for C domain bang fixCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>(cherry picked from commit9148c0d)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 3, 2022
…GH-97741)*pythongh-97740: Fix bang in Sphinx C domain ref target syntaxCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>* Add NEWS entry for C domain bang fixCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>(cherry picked from commit9148c0d)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull requestOct 3, 2022
*gh-97740: Fix bang in Sphinx C domain ref target syntaxCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>* Add NEWS entry for C domain bang fixCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>(cherry picked from commit9148c0d)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull requestOct 3, 2022
*gh-97740: Fix bang in Sphinx C domain ref target syntaxCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>* Add NEWS entry for C domain bang fixCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>(cherry picked from commit9148c0d)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
carljm added a commit to carljm/cpython that referenced this pull requestOct 3, 2022
* main: (2069 commits)pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)pythongh-94808: Coverage: Check picklablability of calliter (python#95923)pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765) Fix typos in `bltinmodule.c`. (pythonGH-97766)pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)pythongh-97681: Remove Tools/demo/ directory (python#97682) Fix typo in unittest docs (python#97742)pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738) [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919) ...
pablogsal pushed a commit that referenced this pull requestOct 22, 2022
*gh-97740: Fix bang in Sphinx C domain ref target syntaxCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>* Add NEWS entry for C domain bang fixCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>(cherry picked from commit9148c0d)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Presently,
!doesn't work in Sphinx C domain reference target syntax in the docs due to an issue withc_allow_pre_v3causing.disabledto be ignored.@AA-Turner developed a workaround to fix that, which I apply here in theconf.py.!in C domain ref target syntax #97740