Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-82836: fix private network check#97733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 7 commits intopython:mainfromJamoBox:fix-issue-82836
Nov 29, 2022

Conversation

@JamoBox
Copy link
Contributor

@JamoBoxJamoBox commentedOct 2, 2022
edited by bedevere-bot
Loading

Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".

Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".
JamoBoxand others added2 commitsOctober 4, 2022 22:05
@JamoBox
Copy link
ContributorAuthor

@JelleZijlstra /@ammaraskar - are you able to take a look at this with the fixes in mind?

@JelleZijlstraJelleZijlstra self-requested a reviewNovember 15, 2022 19:10
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good and the tests are thorough, but I'm not sufficiently familiar with the module to merge this.

@gpsheadgpshead added type-bugAn unexpected behavior, bug, or error stdlibStandard Library Python modules in the Lib/ directory needs backport to 3.11only security fixes labelsNov 29, 2022
@gpsheadgpshead merged commited39109 intopython:mainNov 29, 2022
@miss-islington
Copy link
Contributor

Thanks@JamoBox for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99887 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelNov 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 29, 2022
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".(cherry picked from commited39109)Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
miss-islington added a commit that referenced this pull requestNov 29, 2022
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".(cherry picked from commited39109)Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull requestDec 1, 2022
* main: (112 commits)pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)pythongh-89189: More compact range iterator (pythonGH-27986)  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)pythonGH-99877)  Fix typo in exception message in `multiprocessing.pool` (python#99900)pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)pythonGH-81057: remove static state from suggestions.c (python#99411)  Improve zip64 limit error message (python#95892)pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)pythongh-82836: fix private network check (python#97733)  Docs: improve accuracy of socketserver reference (python#24767)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@gpsheadgpsheadgpshead approved these changes

Assignees

No one assigned

Labels

stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JamoBox@miss-islington@bedevere-bot@gpshead@JelleZijlstra

[8]ページ先頭

©2009-2025 Movatter.jp