Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-97591: InException.__setstate__(), acquire strong reference before callingtp_hash slot.#97700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ofey404
Copy link
Contributor

@ofey404ofey404 commentedOct 1, 2022•
edited
Loading

Added anPy_INCREF / Py_DECREF pair around the call oftp_hash slot inException.__setstate__().

If the last reference of dict value is cleared (bydict.clear()), during the__setstate__ method call, it would cause gc crash.

A script to reproduce this is in#97591 :

importgcclassKey(str):def__hash__(self):d.clear()return0classValue(str):passd= {}d[Key()]=Value()e=Exception()e.__setstate__(d)gc.collect()# Segfault happens here

Similiar issue:#92930

@kumaraditya303kumaraditya303 added type-bugAn unexpected behavior, bug, or error needs backport to 3.10only security fixes needs backport to 3.11only security fixes type-crashA hard crash of the interpreter, possibly with a core dump labelsOct 1, 2022
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LG, I just think you could add your name to the NEWS item.

…e-97591.pw6kkH.rstCo-authored-by: Guido van Rossum <gvanrossum@gmail.com>
@ofey404
Copy link
ContributorAuthor

@kumaraditya303 I notice the “back port to 3.10/11” tag, and I wonder how to do the back port? If it’s proper I’d like to do it.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Regarding the backport, this is usually taken care of automatically by the Miss-Islington bot. Only if there are git merge problems the bot can't do it, a manual backport is required. In that case you're welcome to try it.

@gvanrossumgvanrossum merged commitd639438 intopython:mainOct 2, 2022
@miss-islington
Copy link
Contributor

Thanks@ofey404 for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97716 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 2, 2022
@bedevere-bot
Copy link

GH-97717 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 2, 2022
…es before calling `tp_hash` slot (pythonGH-97700)(cherry picked from commitd639438)Co-authored-by: Ofey Chan <ofey206@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 2, 2022
…es before calling `tp_hash` slot (pythonGH-97700)(cherry picked from commitd639438)Co-authored-by: Ofey Chan <ofey206@gmail.com>
@gvanrossum
Copy link
Member

You're lucky, the backports happened automatically. They'll be merged as soon as the tests pass (since I pre-approved them).

miss-islington added a commit that referenced this pull requestOct 2, 2022
…ore calling `tp_hash` slot (GH-97700)(cherry picked from commitd639438)Co-authored-by: Ofey Chan <ofey206@gmail.com>
miss-islington added a commit that referenced this pull requestOct 2, 2022
…ore calling `tp_hash` slot (GH-97700)(cherry picked from commitd639438)Co-authored-by: Ofey Chan <ofey206@gmail.com>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull requestOct 2, 2022
carljm added a commit to carljm/cpython that referenced this pull requestOct 3, 2022
* main: (2069 commits)pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)pythongh-94808: Coverage: Check picklablability of calliter (python#95923)pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765)  Fix typos in `bltinmodule.c`. (pythonGH-97766)pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)pythongh-97681: Remove Tools/demo/ directory (python#97682)  Fix typo in unittest docs (python#97742)pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738)  [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

Assignees
No one assigned
Labels
type-bugAn unexpected behavior, bug, or errortype-crashA hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@ofey404@miss-islington@bedevere-bot@gvanrossum@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp