Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-87597: Document TimeoutExpired.stdout & .stderr types.#97685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
gpshead merged 2 commits intopython:mainfromgpshead:docs/subprocess-timeoutexpired-bytesSep 30, 2022
Merged
gh-87597: Document TimeoutExpired.stdout & .stderr types.#97685
gpshead merged 2 commits intopython:mainfromgpshead:docs/subprocess-timeoutexpired-bytesSep 30, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This documents the behavior that has always been the case since timeoutsupport was introduced in Python 3.3.
That is is None even when people ask to capture output but the processgenerated no output is a long standing API wart.
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11. |
bedevere-bot commentedSep 30, 2022
GH-97686 is a backport of this pull request to the3.11 branch. |
bedevere-bot commentedSep 30, 2022
GH-97687 is a backport of this pull request to the3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 30, 2022
…nGH-97685)This documents the behavior that has always been the case since timeoutsupport was introduced in Python 3.3.(cherry picked from commitb05dd79)Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 30, 2022
…nGH-97685)This documents the behavior that has always been the case since timeoutsupport was introduced in Python 3.3.(cherry picked from commitb05dd79)Co-authored-by: Gregory P. Smith <greg@krypto.org>
bedevere-bot commentedSep 30, 2022
GH-97688 is a backport of this pull request to the3.9 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 30, 2022
…nGH-97685)This documents the behavior that has always been the case since timeoutsupport was introduced in Python 3.3.(cherry picked from commitb05dd79)Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull requestSep 30, 2022
miss-islington added a commit that referenced this pull requestSep 30, 2022
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull requestOct 2, 2022
…n#97685)This documents the behavior that has always been the case since timeoutsupport was introduced in Python 3.3.
ambv pushed a commit that referenced this pull requestOct 4, 2022
hauntsaninja added a commit to hauntsaninja/typeshed that referenced this pull requestOct 12, 2022
Seepython/cpython#97685Thinking we'll go off of mypy_primer to decide if the union type here isacceptable or not. I'd like us to be able to type this, since the valuesbeing bytes can be surprising if you pass text=True
hauntsaninja added a commit to python/typeshed that referenced this pull requestOct 12, 2022
Seepython/cpython#97685The union type should be acceptable givenpython/cpython#87597 (comment). In general I'd like us to be able to type this, since these being bytes can be surprising if you pass text=True, but we'll see what mypy_primer says
pablogsal pushed a commit that referenced this pull requestOct 22, 2022
Paro131 commentedDec 3, 2022
Thx |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This documents the behavior that has always been the case since timeout support was introduced in Python 3.3.