Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Add re.VERBOSE flag documentation example#97678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ghost commentedSep 30, 2022 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Doc/library/re.rst Outdated
Comment on lines 786 to 787
| or within tokens like ``*?``, ``(?:`` or ``(?P<...>`` (e.g. ``(? :`` or ``* | ||
| ?``). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It would be clearer to say something like "For example,(? : and* ? are not allowed."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the review :)
Fixed as suggested.
The current re.VERBOSE documentation example leaves space for ambiguousinterpretation. One may read that spaces within the `(?:` token arespaces inside the non-capturing group (such as `(?: )`). This patchremoves the ambiguity by including examples after the statement.
cf623b3 to5861f53CompareThanks@athos-ribeiro for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Thanks@athos-ribeiro for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks@athos-ribeiro for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
bedevere-bot commentedOct 5, 2022
GH-97882 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 5, 2022
The current re.VERBOSE documentation example leaves space for ambiguousinterpretation. One may read that spaces within the `(?:` token arespaces inside the non-capturing group (such as `(?: )`). This patchremoves the ambiguity by including examples after the statement.(cherry picked from commit0ceafa7)Co-authored-by: Athos Ribeiro <athoscribeiro@gmail.com>
bedevere-bot commentedOct 5, 2022
GH-97883 is a backport of this pull request to the3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 5, 2022
The current re.VERBOSE documentation example leaves space for ambiguousinterpretation. One may read that spaces within the `(?:` token arespaces inside the non-capturing group (such as `(?: )`). This patchremoves the ambiguity by including examples after the statement.(cherry picked from commit0ceafa7)Co-authored-by: Athos Ribeiro <athoscribeiro@gmail.com>
miss-islington added a commit that referenced this pull requestOct 5, 2022
The current re.VERBOSE documentation example leaves space for ambiguousinterpretation. One may read that spaces within the `(?:` token arespaces inside the non-capturing group (such as `(?: )`). This patchremoves the ambiguity by including examples after the statement.(cherry picked from commit0ceafa7)Co-authored-by: Athos Ribeiro <athoscribeiro@gmail.com>
miss-islington added a commit that referenced this pull requestOct 5, 2022
The current re.VERBOSE documentation example leaves space for ambiguousinterpretation. One may read that spaces within the `(?:` token arespaces inside the non-capturing group (such as `(?: )`). This patchremoves the ambiguity by including examples after the statement.(cherry picked from commit0ceafa7)Co-authored-by: Athos Ribeiro <athoscribeiro@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull requestOct 6, 2022
* main: (66 commits)pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879) docs(typing): add "see PEP 675" to LiteralString (python#97926)pythongh-97850: Remove all known instances of module_repr() (python#97876) I changed my surname early this year (python#96671)pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)pythongh-91539: improve performance of get_proxies_environment (python#91566) build(deps): bump actions/stale from 5 to 6 (python#97701)pythonGH-95172 Make the same version `versionadded` oneline (python#95172)pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383)pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759)pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251)pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662)pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644)pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756)pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778)pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826) Add re.VERBOSE flag documentation example (python#97678) ...
mpage pushed a commit to mpage/cpython that referenced this pull requestOct 11, 2022
The current re.VERBOSE documentation example leaves space for ambiguousinterpretation. One may read that spaces within the `(?:` token arespaces inside the non-capturing group (such as `(?: )`). This patchremoves the ambiguity by including examples after the statement.
pablogsal pushed a commit that referenced this pull requestOct 22, 2022
The current re.VERBOSE documentation example leaves space for ambiguousinterpretation. One may read that spaces within the `(?:` token arespaces inside the non-capturing group (such as `(?: )`). This patchremoves the ambiguity by including examples after the statement.(cherry picked from commit0ceafa7)Co-authored-by: Athos Ribeiro <athoscribeiro@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current re.VERBOSE documentation example leaves space for ambiguous interpretation. One may read that spaces within the
(?:token are spaces inside the non-capturing group (such as(?: )). This patch removes the ambiguity by including examples after the statement.