Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-97588: Failing tests to demonstrate the issue#97589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@matthiasgoergens
Copy link
Contributor

@matthiasgoergensmatthiasgoergens commentedSep 27, 2022•
edited
Loading

The tests are expected to fail, and are marked as such.

@bedevere-botbedevere-bot added awaiting review testsTests in the Lib/test dir labelsSep 27, 2022
@matthiasgoergensmatthiasgoergens changed the titlegh-97588: Some tests to demonstrate the issuegh-97588: Failing tests to demonstrate the issueSep 30, 2022
@matthiasgoergens
Copy link
ContributorAuthor

@mdickinson I marked the tests as failing, so we cant potentially get them intomain as a basis for further work.

Copy link
Contributor

@nanjekyejoannahnanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't we be patching a fix instead? Unless we are accepting this as desired behaviour.

@matthiasgoergens
Copy link
ContributorAuthor

@nanjekyejoannah See#97702 for the fix.

Copy link
Contributor

@nanjekyejoannahnanjekyejoannah left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Then we close this to merge the fix instead, no?

@matthiasgoergens
Copy link
ContributorAuthor

@nanjekyejoannah I'm not completely confident in the fix, yet. But I am confident that these test cases are good.

Not sure we have a general policy against contributing failing test cases?

Copy link
Contributor

@nanjekyejoannahnanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The tests test the failing caes. But with the fix, these tests will change i.e not failing, I would prefer reviewing a PR with a fix and updated tests, since there is a fix. What do you think?

@matthiasgoergens
Copy link
ContributorAuthor

@nanjekyejoannah Feel free to review#97702

@encukou
Copy link
Member

These were merged with#97702. Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nanjekyejoannahnanjekyejoannahnanjekyejoannah left review comments

Assignees

No one assigned

Labels

awaiting reviewtestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthiasgoergens@encukou@nanjekyejoannah@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp