Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-96512: Move int_max_str_digits setting to PyConfig#96944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 9 commits intopython:mainfromgpshead:cleanup/int-dos-use-pyconfig
Oct 3, 2022

Conversation

gpshead
Copy link
Member

@gpsheadgpshead commentedSep 20, 2022•
edited by bedevere-bot
Loading

It had to live as a global outside of PyConfig for stable ABI reasons in the pre-3.12 backports.

This removes the_Py_global_config_int_max_str_digits and gets rid of the equivalent field in the internalstruct _is PyInterpreterState as code can just use the existing nested config struct within that.

It had to live as a global outside of PyConfig for stable ABI reasons inthe pre-3.12 backports.This removes the `_Py_global_config_int_max_str_digits` and gets rid ofthe equivalent field in the internal `struct _is PyInterpreterState` ascode can just use the existing nested config struct within that.
Also demonstrates that subinterpreters maintain their own limitas a feature.
@gpshead
Copy link
MemberAuthor

This pulls out the important config change from#96568, addressing its comments.

@gpsheadgpshead added type-featureA feature request or enhancement interpreter-core(Objects, Python, Grammar, and Parser dirs) topic-C-API labelsSep 20, 2022
@gpsheadgpshead marked this pull request as ready for reviewSeptember 20, 2022 01:25
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, I like this change overall :-) Here is a first review.

@mdickinsonmdickinson removed their request for reviewSeptember 25, 2022 09:39
@mdickinson
Copy link
Member

Removing myself from review; Victor's got this. :-)

gpshead reacted with heart emoji

@gpshead
Copy link
MemberAuthor

I think this is ready, please take another look@vstinner

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@gpsheadgpshead merged commitb0f89cb intopython:mainOct 3, 2022
@gpsheadgpshead deleted the cleanup/int-dos-use-pyconfig branchOctober 3, 2022 20:56
carljm added a commit to carljm/cpython that referenced this pull requestOct 3, 2022
* main: (2069 commits)pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)pythongh-94808: Coverage: Check picklablability of calliter (python#95923)pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765)  Fix typos in `bltinmodule.c`. (pythonGH-97766)pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)pythongh-97681: Remove Tools/demo/ directory (python#97682)  Fix typo in unittest docs (python#97742)pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738)  [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ambvambvambv left review comments

@vstinnervstinnervstinner approved these changes

Assignees

@gpsheadgpshead

Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-C-APItype-featureA feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@gpshead@mdickinson@ambv@vstinner@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp