Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-94808: CoverPyObject_PyBytes case with custom__bytes__ method#96610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Lib/test/test_long.py Outdated
| self.assertEqual(int.from_bytes(ValidBytes()), 1) | ||
| self.assertRaises(TypeError, int.from_bytes, InvalidBytes) | ||
| self.assertRaises(TypeError, int.from_bytes, MissingBytes) | ||
| self.assertRaises(TypeError, int.from_bytes, RaisingBytes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This shouldn't raise TypeError:
>>> class RaisingBytes:... def __bytes__(self):... 1 / 0... >>> int.from_bytes(RaisingBytes())Traceback (most recent call last): File "<stdin>", line 1, in <module> File "<stdin>", line 3, in __bytes__ZeroDivisionError: division by zeroAnd yet CI is green. Am I missing something? I'm compiling your PR locally now to see what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah it's because you don't instantiate the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, Good catch! Even I missed this.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Thanks@sobolevn for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commentedOct 6, 2022
GH-97960 is a backport of this pull request to the3.11 branch. |
Sorry,@sobolevn and@JelleZijlstra, I could not cleanly backport this to |
… method (pythonGH-96610)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commite39ae6b)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn do you want to do a manual 3.10 backport? |
Yes, will do! |
Thanks! |
* main:pythonGH-88050: fix race in closing subprocess pipe in asyncio (python#97951)pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)pythongh-95986: Fix the example using match keyword (python#95989)pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944)pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929)pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610)pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)pythonGH-88968: Add notes about socket ownership transfers (python#97936)pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)
* main: (53 commits)pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)pythonGH-88050: fix race in closing subprocess pipe in asyncio (python#97951)pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)pythongh-95986: Fix the example using match keyword (python#95989)pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944)pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929)pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610)pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)pythonGH-88968: Add notes about socket ownership transfers (python#97936)pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879) docs(typing): add "see PEP 675" to LiteralString (python#97926)pythongh-97850: Remove all known instances of module_repr() (python#97876) I changed my surname early this year (python#96671)pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)pythongh-91539: improve performance of get_proxies_environment (python#91566) build(deps): bump actions/stale from 5 to 6 (python#97701)pythonGH-95172 Make the same version `versionadded` oneline (python#95172)pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774) ...
bedevere-bot commentedOct 9, 2022
GH-98121 is a backport of this pull request to the3.10 branch. |
…ytes__` method (pythonGH-96610)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>.(cherry picked from commite39ae6b)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
…ytes__` method (pythonGH-96610)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>.(cherry picked from commite39ae6b)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
… method (python#96610)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
There were two options:
_testcapimodule.cfunction to testPyObject_PyBytesdirectly. But, there's alreadypyobject_bytes_from_nullwhich only coversNULLcase. So, it is somewhat coveredPyObject_Bytes, likeint_from_bytes_impl. In this case we not only test C-API itself, but also do something useful for the end implementation (in this caseint.from_bytes)So, I went with
2.Probably it is still possible to add a new
_testcapimodule.cfunction in the next PR.