Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-96471: Add queue shutdown#96474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bedevere-bot commentedSep 1, 2022
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
Note that once this is ready for review we may need three separate reviewers -- one for asyncio, another for multiprocessing, a third for threading. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Lib/asyncio/queues.py Outdated
@@ -113,6 +131,8 @@ async def put(self, item): | |||
Put an item into the queue. If the queue is full, wait until a free | |||
slot is available before adding item. | |||
""" | |||
if self.shutdown_state != _queue_alive: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
an example:
ifself.shutdown_state!=_queue_alive: | |
ifself.shutdown_stateisnot_QueueState.ALIVE: |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
YvesDup commentedFeb 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
This should help:https://devguide.python.org/getting-started/git-boot-camp/ The basic commands you will need are |
@merwok Thank for your feedback. I created my own branch fromEpicWink:queue-shutdown, and I am wondering how to give access to my changes. So may be@EpicWink can merge fromYvesDup:queue-shutdown ? |
Oh I missed that you weren’t the author of the PR! Yes, you can make a pull request from your fork to epicwink’s work, or use the suggestion system here (comment on a line, find suggestion in the toolbar) to paste your new tests. |
I read again theoriginal topic and found nothing about what to do about the 'joined' tasks, threads (or processes). I just complete the |
@YvesDup What is your definition of a "'joined' task or thread"? |
YvesDup commentedFeb 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@gvanrossum: Task (or thread) that has called the |
Co-authored-by: Duprat <yduprat@gmail.com>
Co-authored-by: Duprat <yduprat@gmail.com>
Co-authored-by: Duprat <yduprat@gmail.com>
I'm reviewing@YvesDup 's changes inEpicWink#2 |
I have just created a new PRgh-96471: Add queue shutdown, next step. to resume and continue working on this feature |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.