Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-96397: Document that attributes need not be identifiers#96454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 2 commits intopython:mainfromjeff5:doc-accept-nonid-attrs
Sep 29, 2022

Conversation

jeff5
Copy link
Contributor

@jeff5jeff5 commentedAug 31, 2022•
edited
Loading

Companion to#96393, and stemming from points made in the discussions athttps://discuss.python.org/t/supporting-or-not-invalid-identifiers-in-kwargs/17147/26 and#96397, this proposes extending how we define "attribute" to match the behaviour of implementations and some current user practice.

Needs SC discussion, I believe.

Clarify that the name of an attribute need not be a valid Python identifier, in particular through setarr(), noting that this precludes use of the dot notation to access them.
Copy link
Contributor

@ChrisBarker-NOAAChrisBarker-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me -- I've suggested a bit more verbose text, but not critical.

@jeff5
Copy link
ContributorAuthor

Could this be merged, or have I more to do?

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, one optional suggestion.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@gvanrossumgvanrossum merged commit9a11ed8 intopython:mainSep 29, 2022
@gvanrossumgvanrossum added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsSep 29, 2022
@miss-islington
Copy link
Contributor

Thanks@jeff5 for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@jeff5 for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97658 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsSep 29, 2022
@bedevere-bot
Copy link

GH-97659 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 29, 2022
…honGH-96454)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit9a11ed8)Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 29, 2022
…honGH-96454)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit9a11ed8)Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington added a commit that referenced this pull requestSep 29, 2022
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit9a11ed8)Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington added a commit that referenced this pull requestSep 29, 2022
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit9a11ed8)Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull requestOct 2, 2022
pablogsal pushed a commit that referenced this pull requestOct 22, 2022
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit9a11ed8)Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ChrisBarker-NOAAChrisBarker-NOAAChrisBarker-NOAA left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments

@merwokmerwokmerwok approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@jeff5@miss-islington@bedevere-bot@merwok@ChrisBarker-NOAA@gvanrossum@CAM-Gerlach
[8]ページ先頭
©2009-2025 Movatter.jp