Jan 7, 2023 · Aug 27, 2022
diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py
                         ((('a', 10, ..., "positional_or_keyword"),),
                          ...))

    def test_signature_on_mocks(self):
        # https://github.com/python/cpython/issues/96127
        for mock in (
            unittest.mock.Mock(),
            unittest.mock.AsyncMock(),
            unittest.mock.MagicMock(),
        ):
            with self.subTest(mock=mock):
                self.assertEqual(str(inspect.signature(mock)), '(*args, **kwargs)')

    def test_signature_on_noncallable_mocks(self):
        for mock in (
            unittest.mock.NonCallableMock(),
            unittest.mock.NonCallableMagicMock(),
        ):
            with self.subTest(mock=mock):
                with self.assertRaises(TypeError):
                    inspect.signature(mock)

    def test_signature_equality(self):
        def foo(a, *, b:int) -> float: pass
        self.assertFalse(inspect.signature(foo) == 42)
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
        code_mock = NonCallableMock(spec_set=_CODE_ATTRS)
        code_mock.__dict__["_spec_class"] = CodeType
        code_mock.__dict__["_spec_signature"] = _CODE_SIG
        code_mock.co_flags = inspect.CO_COROUTINE
        code_mock.co_flags = (
            inspect.CO_COROUTINE
            + inspect.CO_VARARGS
            + inspect.CO_VARKEYWORDS
        )
        code_mock.co_argcount = 0
        code_mock.co_varnames = ('args', 'kwargs')
        code_mock.co_posonlyargcount = 0
        code_mock.co_kwonlyargcount = 0
        self.__dict__['__code__'] = code_mock
        self.__dict__['__name__'] = 'AsyncMock'
        self.__dict__['__defaults__'] = tuple()
diff --git a/Misc/NEWS.d/next/Library/2022-08-27-10-35-50.gh-issue-96127.8RdLre.rst b/Misc/NEWS.d/next/Library/2022-08-27-10-35-50.gh-issue-96127.8RdLre.rst
 ``inspect.signature`` was raising ``TypeError`` on call with mock objects.
 Now it correctly returns ``(*args, **kwargs)`` as infered signature.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3283,6 +3283,25 @@ def test_signature_on_lambdas(self):
		((('a', 10, ..., "positional_or_keyword"),),
		...))

		def test_signature_on_mocks(self):
		# https://github.com/python/cpython/issues/96127
		for mock in (
		unittest.mock.Mock(),
		unittest.mock.AsyncMock(),
		unittest.mock.MagicMock(),
		):
		with self.subTest(mock=mock):
		self.assertEqual(str(inspect.signature(mock)), '(args, *kwargs)')

		def test_signature_on_noncallable_mocks(self):
		for mock in (
		unittest.mock.NonCallableMock(),
		unittest.mock.NonCallableMagicMock(),
		):
		with self.subTest(mock=mock):
		with self.assertRaises(TypeError):
		inspect.signature(mock)

		def test_signature_equality(self):
		def foo(a, *, b:int) -> float: pass
		self.assertFalse(inspect.signature(foo) == 42)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2213,7 +2213,15 @@ def __init__(self, /, args, *kwargs):
		code_mock = NonCallableMock(spec_set=_CODE_ATTRS)
		code_mock.__dict__["_spec_class"] = CodeType
		code_mock.__dict__["_spec_signature"] = _CODE_SIG
		code_mock.co_flags = inspect.CO_COROUTINE
		code_mock.co_flags = (
cjw296 marked this conversation as resolved. Show resolvedHide resolved
		inspect.CO_COROUTINE
		+ inspect.CO_VARARGS
		+ inspect.CO_VARKEYWORDS
		)
		code_mock.co_argcount = 0
		code_mock.co_varnames = ('args', 'kwargs')
		code_mock.co_posonlyargcount = 0
		code_mock.co_kwonlyargcount = 0
cjw296 marked this conversation as resolved. Show resolvedHide resolved
		self.__dict__['__code__'] = code_mock
		self.__dict__['__name__'] = 'AsyncMock'
		self.__dict__['__defaults__'] = tuple()
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		``inspect.signature`` was raising ``TypeError`` on call with mock objects.
		Now it correctly returns ``(args, *kwargs)`` as infered signature.