Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-96175: add missing self._localName assignment inxml.dom.minidom.Attr#96176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 10 commits intopython:mainfromkkirsche:patch-2
Aug 23, 2022

Conversation

@kkirsche
Copy link
Contributor

@kkirschekkirsche commentedAug 22, 2022•
edited
Loading

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@ghost
Copy link

ghost commentedAug 22, 2022•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@kkirsche
Copy link
ContributorAuthor

CLA stuff is borked:

CleanShot 2022-08-22 at 10 28 10@2x

@JelleZijlstra
Copy link
Member

Thank you!

cc@ambv for the CLA bot throwing a 500.

Could you add a unit test and a NEWS entry? You can use blurb as documented under 8 athttps://devguide.python.org/?highlight=blurb#quick-reference.

@JelleZijlstraJelleZijlstra self-assigned thisAug 22, 2022
@JelleZijlstraJelleZijlstra added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsAug 22, 2022
@kkirsche
Copy link
ContributorAuthor

Could you add a unit test and a NEWS entry? You can use blurb as documented under 8 athttps://devguide.python.org/?highlight=blurb#quick-reference.

I'll give it my best shot, I have that cloning so I can add those in after my next meeting this afternoon. Thanks for the opportunity to contribute this to cpython, it's a project where the must have an issue requirement in the contributing guide has kept me away in the past.

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

1 similar comment
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@kkirsche
Copy link
ContributorAuthor

I've added my attempt at this. If I did anything incorrectly or without enough detail, please let me know.

It may also be useful to give an example inblurb about what a good paragraph would look like.

@kkirsche
Copy link
ContributorAuthor

kkirsche commentedAug 22, 2022•
edited
Loading

I have tried to sign the CLA, but have been unable to. Sometimes it shows up as signed, other times it doesn't, so wanted to comment here explicitly.

@JelleZijlstra
Copy link
Member

The CLA actually seems fine, the check in CI is succeeding.

kkirsche reacted with thumbs up emoji

@JelleZijlstraJelleZijlstra merged commit58f6953 intopython:mainAug 23, 2022
@miss-islington
Copy link
Contributor

Thanks@kkirsche for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@kkirsche and@JelleZijlstra, I had trouble checking out the3.11 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 58f6953d6d3fe20d972bfa2f6e982206adcf1353 3.11

@JelleZijlstra
Copy link
Member

Thank you for your contribution!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 23, 2022
…nidom.Attr` (pythonGH-96176)X-Ref:https://github.com/python/typeshed/pull/8590GH-discussion_r951473977Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commit58f6953)Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelAug 23, 2022
@bedevere-bot
Copy link

GH-96212 is a backport of this pull request to the3.10 branch.

@JelleZijlstraJelleZijlstra added needs backport to 3.11only security fixes and removed needs backport to 3.11only security fixes labelsAug 23, 2022
@miss-islington
Copy link
Contributor

Thanks@kkirsche for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

kkirsche reacted with thumbs up emoji

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelAug 23, 2022
@bedevere-bot
Copy link

GH-96213 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 23, 2022
…nidom.Attr` (pythonGH-96176)X-Ref:https://github.com/python/typeshed/pull/8590GH-discussion_r951473977Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commit58f6953)Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
miss-islington added a commit that referenced this pull requestAug 23, 2022
…Attr` (GH-96176)X-Ref:https://github.com/python/typeshed/pull/8590GH-discussion_r951473977Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commit58f6953)Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
@kkirsche
Copy link
ContributorAuthor

Thank you for your contribution!

Thank you for your time reviewing this and your patience explaining why decisions are being made as I learn more about CPython.

miss-islington added a commit that referenced this pull requestAug 23, 2022
…Attr` (GH-96176)X-Ref:https://github.com/python/typeshed/pull/8590GH-discussion_r951473977Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commit58f6953)Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
@kkirschekkirsche deleted the patch-2 branchAugust 23, 2022 18:25
mdboom pushed a commit to mdboom/cpython that referenced this pull requestAug 24, 2022
…nidom.Attr` (python#96176)X-Ref:python/typeshed#8590 (comment)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

Assignees

@JelleZijlstraJelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xml.dom.minidom:Attr.__init__ doesn't use localName variable.

4 participants

@kkirsche@bedevere-bot@JelleZijlstra@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp