Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-88233: zipfile: handle extras after a zip64 extra#96161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Can you add a NEWS entry (https://pypi.org/project/blurb/ can help) describing the bugfix? |
Previously, any data _after_ the zip64 extra would be removed.With many new tests.Fixespython#88233
Rebased and NEWS entry added. |
@gpshead would you like me to do anything else on this one? NEWS entry is added. |
@gpshead any other changes you'd like to see on this one? |
(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why?Read here.) Looks like this is complete. Can someone merge it so it doesn't get too stale? |
@gpshead (as the zipfile expert), would you mind to review and possibly merge this PR? |
This one is likely good,@jaraco is ourreal zipfile expert though. looping him in before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. I had some minor nitpicks with the test, so took the liberty to correct those. I also replaced the literal1 with ZIP64_EXTRA in the hopes of more clearly communicating that aspect.
Status check is done, and it's a success ✅. |
Thanks@thatch for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
…96161)Previously, any data _after_ the zip64 extra would be removed.With many new tests.FixespythonGH-88233(cherry picked from commit59e86ca)Co-authored-by: Tim Hatch <tim@timhatch.com>Automerge-Triggered-By: GH:jaraco
bedevere-bot commentedFeb 20, 2023
GH-102086 is a backport of this pull request to the3.11 branch. |
bedevere-bot commentedFeb 20, 2023
GH-102087 is a backport of this pull request to the3.10 branch. |
…96161)Previously, any data _after_ the zip64 extra would be removed.With many new tests.FixespythonGH-88233(cherry picked from commit59e86ca)Co-authored-by: Tim Hatch <tim@timhatch.com>Automerge-Triggered-By: GH:jaraco
* main: (60 commits)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)pythongh-97786: Fix compiler warnings in pytime.c (python#101826)pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052)pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049)pythongh-100210: Correct the comment link for unescaping HTML (python#100212)pythongh-97930: Also include subdirectory in makefile. (python#102030)pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250)pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...
* main: (225 commits)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)pythongh-97786: Fix compiler warnings in pytime.c (python#101826)pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052)pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049)pythongh-100210: Correct the comment link for unescaping HTML (python#100212)pythongh-97930: Also include subdirectory in makefile. (python#102030)pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250)pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...
…96161)Previously, any data _after_ the zip64 extra would be removed.With many new tests.Fixespython#88233Automerge-Triggered-By: GH:jaraco
…96161)Previously, any data _after_ the zip64 extra would be removed.With many new tests.Fixespython#88233Automerge-Triggered-By: GH:jaraco
Uh oh!
There was an error while loading.Please reload this page.
Previously, any dataafter the zip64 extra would be removed.
With many new tests.
Fixes#88233
Automerge-Triggered-By: GH:jaraco